harvest.net icon indicating copy to clipboard operation
harvest.net copied to clipboard

Published 20 hours ago • verified publisher icon ithielnor

.net core support

Open asoet opened this issue 7 years ago • 11 comments

Are you planning to support .net core? I know restsharp does not have .net core support yet.

asoet avatar Dec 22 '16 12:12 asoet

Perhaps as part of 2.0. Haven't really looked into it.

ithielnor avatar Dec 23 '16 16:12 ithielnor

Okay thanks. Do you have a roadmap?

asoet avatar Jan 20 '17 13:01 asoet

Just what's tracked here: https://github.com/ithielnor/harvest.net/milestone/2

ithielnor avatar Jan 20 '17 13:01 ithielnor

I'll gladly take this one once #75 is confirmed good to go and merged in.

paulirwin avatar Sep 28 '17 16:09 paulirwin

Refit is a good replacement for restsharp, if it still doesn't support net core.

kfrancis avatar Sep 28 '17 18:09 kfrancis

I just converted it to .Net Standard 2.0 for my personal project. The unit tests all pass, but I don't know if it's worth making a PR for or not because I had to convert the visual basic TextFieldParser to a CvsHelper project I found in Nuget and I don't use that functionality, so I can't guarantee I did it correctly. It's here if anyone wants it: https://github.com/lprichar/harvest.net and I'm happy to make a PR if the authors would like.

lprichar avatar Jan 28 '18 23:01 lprichar

@lprichar Awesome, this is only possible now because RestSharp now supports .NET Standard 2.0. It didn't at the time that I started a rather ambitious rewrite. I'd still like to continue down that path but it's of less importance now. Please create a PR, I'd like to review and help test.

paulirwin avatar Feb 07 '18 15:02 paulirwin

@lprichar Looks cool. Can you submit a PR to 2.0?

ithielnor avatar Feb 07 '18 16:02 ithielnor

@lprichar Can you make a PR for this? I've successfully tested it and at least for my use it works well.

paulirwin avatar Jun 20 '18 13:06 paulirwin

I'm happy to PR it against master, but redoing it for 2.0 would be non-trivial. I guess I'll just do that, and then the maintainers (@ithielnor) can reject it, and I won't be mortally offended.

lprichar avatar Jun 20 '18 13:06 lprichar

At this point, I'd consider your port to .NET Standard to be 2.0, and any future refactorings/rewrites to be 3.0+. "Perfect is the enemy of the good" and all.

paulirwin avatar Jun 20 '18 13:06 paulirwin