pharos
pharos copied to clipboard
Pharos Menu styling issue when the last menu item is an mfe being mounted
Expected behavior Second to last menu item is lacking border.
Actual behavior Each menu item has a border except for the last one.
Steps to reproduce the issue
- Create a pharos menu with three items, two vanilla menu items, one citation menu item (from mfe-citation)
- Note that the second to last menu item is lacking border.
Screenshots or code
Pharos version Indicate which version of Pharos you are using.
Your environment
- OS: [e.g. macOS]
- Browser: [e.g. Chrome, Firefox, Safari]
- Version: [e.g. 88]
Additional information I think a way to fix this to have some type of observer in the menu which is watching to see how the menu changes over time, and re-rendering.
@ymouzakis thanks for reporting; I agree this is probably because the slotted content is changed after the component is initially created. One approach may be to call this.requestUpdate() on the slotchange event in the DropdownMenu's code.