pharos icon indicating copy to clipboard operation
pharos copied to clipboard

Loading spinner: Have option to remove the overlay

Open michael-iden opened this issue 1 year ago • 1 comments

The problem We are considering putting loading spinners on secondary buttons as an indication that the user action from the click is happening for certain workflows. We have a small loading spinner that works well in a button but it applies an overlay internally to the button but not the button padding that looks rather strange. We also have an "on background" loading spinner that does remove the overlay but the spinner portion itself is white, which won't be visible on a secondary button.

The solution Create a property to remove the semi-transparent overlay from the primary red loading spinner

Alternatives considered Use other button types such as primary.

Additional information Current UX with a loading spinner on a disabled secondary button image

michael-iden avatar Sep 16 '24 16:09 michael-iden

In my view this might stretch the intended use case of the loading spinner as-designed. If we intend to extend to these hyper-focused uses, we might consider doing a broader revisit to ensure the design is as supportive as it can be (vs. e.g. adding a no-overlay prop or something)

daneah avatar Sep 16 '24 17:09 daneah