Upgrade to Lit 3 and latest scoped element packages
This change: (check at least one)
- [ ] Adds a new feature
- [ ] Fixes a bug
- [x] Improves maintainability
- [ ] Improves documentation
- [ ] Is a release activity
Is this a breaking change? (check one)
- [ ] Yes
- [x] No
Is the: (complete all)
- [x] Title of this pull request clear, concise, and indicative of the issue number it addresses, if any?
- [x] Test suite(s) passing?
- [x] Code coverage maximal?
- [x] Changeset added?
- [ ] Component status page up to date?
What does this change address?
- Resolves #634
- Resolves #745
How does this change work?
- Upgrade to Lit 3
- Upgrade
@lit-labs/scoped-registry-mixin - Upgrade
@webcomponents/scoped-custom-element-registry - Update unit tests to pass, keeping their functional spirit
Additional context
This upgrade altered two things, as exposed by the unit tests:
- Chrome no longer appears to fire an element's
clickhandler if it has thedisabledattribute - Webkit no longer seems to include underlying native elements in the
composedPathforfocusin
🦋 Changeset detected
Latest commit: 77c63fd03a0168711940b5785523f8fe06b15979
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
| Name | Type |
|---|---|
| @ithaka/pharos | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
size-limit report 📦
| Path | Size |
|---|---|
| packages/pharos/lib/index.js | 63.95 KB (-1.08% 🔽) |
There appears to be something different with how the attributes are being rendered with respect to Storybook's story args—in particular, boolean arguments aren't working properly. We previously had to mess with this, and maybe it's flipped back somehow.
There appears to be something different with how the attributes are being rendered with respect to Storybook's story args—in particular, boolean arguments aren't working properly. We previously had to mess with this, and maybe it's flipped back somehow.
Oop, yep you are correct, there is some weirdness with how things are rendered in Storybook right now. Probs shouldn't have approved that 🙃
There appears to be something different with how the attributes are being rendered with respect to Storybook's story args—in particular, boolean arguments aren't working properly.
@Niznikr any chance you've run into this? I'm about at wit's end trying different things here 😓
It might be an issue with Storybook as the issue reporter also seems to be using Lit 3 and the symptoms seem similar. https://github.com/storybookjs/storybook/issues/28634
@Niznikr thanks for the link—had been looking around a bit in their issues but missed that one. It's a slightly different manifestation, but agreed that it might reveal a deeper issue. Will keep picking at it a bit, and maybe file a separate issue. Probably good to try a very small repro from scratch using the latest Lit and Storybook I suppose 😄