pharos icon indicating copy to clipboard operation
pharos copied to clipboard

Pharos site mobile navigation menu has no way to close

Open shoupeva-ithaka opened this issue 1 year ago • 1 comments

Expected behavior The side navigation is hidden by default, a menu icon button is present to open the side navigation, and when it is open it has a close button on mobile.

Actual behavior The side navigation component on mobile is open by default and has no close button.

Steps to reproduce the issue

  1. Go to https://pharos.jstor.org on a mobile device

Screenshots or code image

Pharos version N/A

Your environment

  • OS: M1 Pro Mac – Sonoma 14.2.1
  • Browser: Chrome / Safari

Additional information The side navigation on mobile in the Safari browser also only expands to the navigation bar at the bottom (or the top as I believe that is a configurable setting). It can make for some wonky behavior. I wonder if it is also wise to have the side navigation height expand the entire height of the window instead of the viewport (then maybe an internal container element can only expand the height of the viewport for proper scroll behavior).

shoupeva-ithaka avatar May 29 '24 13:05 shoupeva-ithaka

Likely introduced by #478 (see #417)

daneah avatar Jun 01 '24 20:06 daneah