pharos icon indicating copy to clipboard operation
pharos copied to clipboard

Button: fix styling of buttons with on-background within Vue3 apps

Open michael-iden opened this issue 3 years ago • 2 comments

This change: (check at least one)

  • [ ] Adds a new feature
  • [X] Fixes a bug
  • [ ] Improves maintainability
  • [ ] Improves documentation
  • [ ] Is a release activity

Is this a breaking change? (check one)

  • [X] Yes
  • [ ] No

Is the: (complete all)

  • [X] Title of this pull request clear, concise, and indicative of the issue number it addresses, if any?
  • [ ] Test suite(s) passing?
  • [ ] Code coverage maximal?
  • [ ] Changeset added?

What does this change address? Fixes #307

How does this change work? Changes the on-background to is-on-background

Additional context Yalc'd this change over the the Vue3 app and confirmed the button displays correctly when prefixed with is-

michael-iden avatar Feb 09 '22 17:02 michael-iden

⚠️ No Changeset found

Latest commit: bed8ef36537efe028b2151903158f202c5201fb1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Feb 09 '22 17:02 changeset-bot[bot]

size-limit report 📦

Path Size
packages/pharos/lib/index.js 47.94 KB (+0.2% 🔺)

github-actions[bot] avatar Feb 09 '22 17:02 github-actions[bot]

This is only one of a few components that have an on-background attribute, by the looks of it. I would suggest we can eventually merge this pull request without changing those other components, but we might want to broaden #307 to all relevant components and remove Fixes #307 from this PR so that it doesn't get erroneously closed.

daneah avatar Jan 17 '23 20:01 daneah

Subsumed by #578, #657, and possibly others.

daneah avatar Jan 04 '24 17:01 daneah