Gray border with transparent png: from 5.2.0

[wclr]

I have original image:

From 5.2.0 the result image has gray border:

In early version there is no border.

There also was an issue before: https://github.com/itgalaxy/favicons/issues/123

[alexander-akait]

@whitecolor feel free to send a PR with fix

[wclr]

I think it is quite a severe regression btw. For now I prefer just to downgrade https://github.com/brunocodutra/webapp-webpack-plugin

@brunocodutra

[brunocodutra]

@whitecolor any idea where the border is coming from?

[wclr]

Well, should be some stuff related to picture generation? Maybe svg2png? Need to see what changed between favicons 5.1.1 and 5.2.0.

[brunocodutra]

Right, it was certainly due to some dependency being updated, in which case this issue needs to be reported upstream once we find the culprit.

[egemon]

Sorry guys, thank u for doing such a good stuff. Do u think we can see a fix in some time?

[alexander-akait]

PR welcome, it is open source and many peoples don't have enough time

[brunocodutra]

Actually a recent PR #254 replaced svg2png by sharp. @egemon do you have the means to test favicons@master and verify that the issue is gone?

[mikroware]

So that PR only changed the handling over svg images? I have this gray border issue with png images. So that PR would not have fixed my case. I will try to test this soon though and also export my image to svg to see if that works better.

[brunocodutra]

Good point, I don't see why we use both Jimp and Sharp, we should move to Sharp everywhere.

@kghost Do you think you can help us out?

[nirui]

The same problem brought me here.

And actually, I found that when .svg file is used instead of the .png one, the problem is gone.

I don't actually know any detail on the issue, but maybe take a look at the parameter used during PNG file processing?

[wclr]

@niruix thanks for pointing to svg solution.

[papiliond]

I still have this issue.