rups icon indicating copy to clipboard operation
rups copied to clipboard

Try to get a little more information into the error dialogue.

Open YoungJules opened this issue 5 months ago • 2 comments

Update getTraceString in ErrorDialogPane to show the error message and cause, if available. Catch exceptions that occur in doInBackground of ObjectLoader. This means at least some part of the pdf file gets loaded, although we've hit an error condition in a bad pdf file.

YoungJules avatar Jul 23 '25 06:07 YoungJules

This means at least some part of the pdf file gets loaded

Hmm, I am not quite sure on how safe it is... My gut feeling says, that RUPS will explode after that at some point. I'd rather keep it like it is here with just an abort for now. And, maybe, revisit partial loading at some later point with some rigorous testing along the way.

As for the messaging change, if you don't mind, I can just cherry-pick it into https://github.com/itext/rups/pull/172 with authorship preserved and then merge it all together.

Eswcvlad avatar Jul 28 '25 13:07 Eswcvlad

As for the messaging change, if you don't mind, I can just cherry-pick it into https://github.com/itext/rups/pull/172 with authorship preserved and then merge it all together.

No worries :-)

I am not quite sure on how safe it is... My gut feeling says, that RUPS will explode after that at some point. I'd rather keep it like it is

No worries... I understand your worries about RUPS exploding...

YoungJules avatar Jul 28 '25 13:07 YoungJules

Merged the error message changes in f8f72b84f60cf3aa402f0598248078f31796aba1.

Eswcvlad avatar Nov 25 '25 18:11 Eswcvlad