itext-java icon indicating copy to clipboard operation
itext-java copied to clipboard

Published 20 hours ago • verified publisher icon itext

fixing a missing index

Open tohidemyname opened this issue 1 year ago • 3 comments

fix missing index and newlines in cleanup regexes

tohidemyname avatar Jul 02 '24 04:07 tohidemyname

Hi @tohidemyname , Thank you for your contribution!

Would you mind signing the Contributor License Agreement? The details are available at https://itextpdf.com/en/how-buy/legal/itext-contributor-license-agreement We need it in order to be able to merge your PR

On a separate note, could you please provide some information on the issue you are fixing with this PR? You could describe it here or simply add a test case in the PR itself.

yulian-gaponenko avatar Jul 04 '24 07:07 yulian-gaponenko

@yulian-gaponenko Thanks for the introduction. I have filed and emailed my agreement. Please let me know if you need more materials.

tohidemyname avatar Jul 17 '24 06:07 tohidemyname

Hi @tohidemyname I'm afraid we can't find your email. Have you sent it to the [email protected] ?

yulian-gaponenko avatar Jul 29 '24 12:07 yulian-gaponenko

Hi @tohidemyname After deeper investigation it appears that the fix is not correct or not full. We intentionally don't put word and line separators (spaces and line endings) into indexMap not to assign them to any of the content found in the document. Your fix breaks the behavior and quite some automated tests.

It feels like you have an issue (exception?) on some particular content and a regexp. But looking at our code I can't see where the problem can occur.

Could you, please add a sample showing what your fix is supposed to fix exactly and we will come up with a solution.

vitali-pr avatar Sep 10 '24 06:09 vitali-pr

I'm closing this PR. We will reopen it after getting more info from @tohidemyname .

vitali-pr avatar Sep 23 '24 12:09 vitali-pr