vscode-dvc icon indicating copy to clipboard operation
vscode-dvc copied to clipboard

Improve the walkthrough image style

Open maxagin opened this issue 3 years ago • 5 comments

maxagin avatar Oct 15 '22 15:10 maxagin

Sorry @mattseddon , I thought the images are replaced with the code snippets. Will create an update now.

maxagin avatar Oct 17 '22 15:10 maxagin

@maxagin all of the experiments table screenshots are out of date already.

mattseddon avatar Oct 17 '22 22:10 mattseddon

@maxagin all of the experiments table screenshots are out of date already.

@mattseddon do you suggest replacing all the old screenshots?

maxagin avatar Oct 17 '22 23:10 maxagin

@maxagin all of the experiments table screenshots are out of date already.

@mattseddon do you suggest replacing all the old screenshots?

If you are going to take the time to change them then they should be correct. This is the problem of maintaining screenshots alongside an ever-changing application.

mattseddon avatar Oct 17 '22 23:10 mattseddon

Code Climate has analyzed commit 2652e9b0 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.8% (0.0% change).

View more on Code Climate.

codeclimate[bot] avatar Oct 19 '22 04:10 codeclimate[bot]

When the info looks more professional we have better chances to have the user's focus.

Screen.Recording.2022-10-18.at.11.33.50.PM.mov iterative/design#42

@maxagin the demo should be from inside the product.

mattseddon avatar Oct 19 '22 05:10 mattseddon

@mattseddon @maxagin what is left here folks?

shcheklein avatar Nov 12 '22 02:11 shcheklein

@shcheklein resolving the conflict isn't worth the effort as this branch pre-dates the demo project being moved into a submodule. I'll lift the images from this branch into a new one and open a new PR.

mattseddon avatar Nov 20 '22 03:11 mattseddon