vscode-dvc icon indicating copy to clipboard operation
vscode-dvc copied to clipboard
verified publisher icon iterative

Plot & Plot and Show in the context menu

Open maxagin opened this issue 3 years ago • 8 comments

TODO

  • Remove Plot
  • Rename Plots and Show to Plot
  • The context menu in case of a single EXP should have a Plot option.
  • This also needs to work if the user just right-clicks on the EXP (without selecting it).
  • The right-click on EXP does not need to remove the row hover style (if possible).
  • If more than 7 EXPs are selected grey out Plot (always grey out the inactive options. For education the menu can show what is available).
  • Add unplot option (was #2448)

maxagin avatar Oct 07 '22 02:10 maxagin

Should we remove Plot/Plot and show from the context menu if more than 7 EXPs are selected? Need a good solution here.

The current behaviour is to only plot the multi-selected rows.

mattseddon avatar Oct 07 '22 23:10 mattseddon

Should we remove Plot/Plot and show from the context menu if more than 7 EXPs are selected?

No, I think we need to grey out inactive options always. Menu can show what is available (education).

Right-clicking on EXP shows the context menu with options: Plot / Plot and Show. I suggest removing the Plot option, as not essential.

Make sense. We can even rename it to Plot and make it default behavior to active the Plot webview.

shcheklein avatar Oct 09 '22 01:10 shcheklein

I have updated the description.

maxagin avatar Oct 09 '22 02:10 maxagin

Hey @maxagin I would love to tackle this one

math-alpha avatar Oct 13 '22 10:10 math-alpha

@math-alpha please give a try, let us know if you need a hand.

shcheklein avatar Oct 13 '22 17:10 shcheklein

I am unsure what the "unplot" menu is supposed to do. Is that unselecting from the experiments?

math-alpha avatar Oct 15 '22 11:10 math-alpha

@math-alpha it should be doing the opposite from what the Plot option is doing (enables plots for an experiment(s) on the Plots view).

shcheklein avatar Oct 15 '22 14:10 shcheklein

Update

  • [x] Remove Plot
  • [x] Rename Plots and Show to Plot
  • [x] The context menu in case of a single EXP should have a Plot option.
  • [x] This also needs to work if the user just right-clicks on the EXP (without selecting it).
  • [ ] The right-click on EXP does not need to remove the row hover style (if possible).
  • [ ] If more than 7 EXPs are selected grey out Plot (always grey out the inactive options. For education the menu can show what is available).
  • [x] Add unplot option (was https://github.com/iterative/vscode-dvc/issues/2448)

math-alpha avatar Oct 17 '22 09:10 math-alpha