vscode-dvc icon indicating copy to clipboard operation
vscode-dvc copied to clipboard
verified publisher icon iterative

Table header improvements

Open shcheklein opened this issue 3 years ago • 6 comments

  • [x] Remove sort menu option from the parent params column drop down. Check for metrics. (https://github.com/iterative/vscode-dvc/pull/2583)
Screen Shot 2022-08-24 at 1 41 17 PM
  • [ ] Add hide columns / section there (and in every other menu) (https://github.com/iterative/vscode-dvc/pull/2593)
  • [ ] ESC must work to close context menu
  • [ ] The context menu in the header cells should appear only on the right click. Currently also works with the left click (https://github.com/iterative/vscode-dvc/pull/2603)
  • [ ] Add filter by to context menus
  • [ ] Add hover styles to header cells
  • [ ] The sort arrow in the header cell does need to have BG on hover but needs to have a cursor (pointer)
  • [ ] Click on the Sort arrow - the context menu appears - if you hover on the arrow again the tooltip will be shown on top of the context menu. Do not show a tooltip when the menu is opened
  • [ ] The D&D cursor appears when the header block has hovered. Blocks like "Create" have no active space on top. Let's make sure that all the space of the block can be used to D&D
  • [ ] Context menu "Change height" should be available everywhere. Now it doesn't show on metric file column.
  • [ ] Context menu doesn't show on an empty stub on top of a column (e.g. train.py dependecy).

shcheklein avatar Aug 24 '22 20:08 shcheklein

There must be a way to copy file names / section names. Full name and partial name.

Please see: Text selection in the table's header and body cells #2260

maxagin avatar Aug 25 '22 02:08 maxagin

There must be a way to copy file names / section names. Full name and partial name.

It will be handled here https://github.com/iterative/vscode-dvc/issues/2260

maxagin avatar Sep 07 '22 00:09 maxagin

Some of the todo items were moved to #2241

maxagin avatar Sep 07 '22 00:09 maxagin

  • The context menu in the header cells should appear only on the right click. Currently also works with the left click

The description was updated. The new task was included.

maxagin avatar Sep 07 '22 16:09 maxagin

Can “Open to the Side” params, but not training_metrics. Why? If I am not mistaken this should work for any file that can be opened on the side.

maxagin avatar Oct 07 '22 05:10 maxagin

Add hide columns / section there (and in every other menu)

This one is deceptively tricky, I implemented a solution, and now I'm adding/fixing some tests. Still, it will need some manual testing during review to catch side-effects.

Note: The PR is open for this, I'll proceed with the other items in separate PRs

wolmir avatar Oct 13 '22 16:10 wolmir