vscode-dvc icon indicating copy to clipboard operation
vscode-dvc copied to clipboard

Change the exp name just by clicking on the name in column

Open maxagin opened this issue 3 years ago • 12 comments

This is a kinda fast way to help users to have custom information about the experiment. Please let’s discuss this idea. Thanks

Note: we finally will remove the plots toggle on the name and will use just a circle to toggle plots.

maxagin avatar Jul 18 '22 18:07 maxagin

Good idea. The problem is that names are provided and stored in DVC. @dberenbaum @pmrowla is there a way to change them after / where do we store them now?

shcheklein avatar Jul 18 '22 23:07 shcheklein

Note: we finally will remove the plots toggle on the name and will use just a circle to toggle plots.

Not a big fan of this, since circles are too small. So if we do this - it will be a trade off.

shcheklein avatar Jul 18 '22 23:07 shcheklein

Note: we finally will remove the plots toggle on the name and will use just a circle to toggle plots.

Not a big fan of this, since circles are too small. So if we do this - it will be a trade off.

I really hope we will be able to move forward with the standard eye concept. Which to my mind is the most user-friendly solution.

maxagin avatar Jul 19 '22 00:07 maxagin

to move forward with the standard eye concept.

yes, it's not that easy to implement + it will be taking even more space (eyes, checkboxes, stars) + you are biased a bit - when I talk to people who do not come from design that sometimes are not that familia with this concept

shcheklein avatar Jul 19 '22 00:07 shcheklein

when I talk to people who do not come from design that sometimes are not that familia with this concept

I am parry:

Screen Shot 2022-07-18 at 8 27 58 PM

The icons width 18x18px. It looks very compact I think.

Screen Shot 2022-07-18 at 8 30 09 PM

maxagin avatar Jul 19 '22 00:07 maxagin

@maxagin trust me, I've seen this :) And trust me I still had some feedback that an eye icon is not that clear.

shcheklein avatar Jul 19 '22 00:07 shcheklein

Good @shcheklein . We are going to make sure to guide the user ("Explain that circle triggering plots"), even using current circles. The same will work for the eye (if we will decide to have it). So I think that the icon is less important.

Regarding the:

The problem is that names are provided and stored in DVC. @dberenbaum @pmrowla

We could hide the name without modifying it, and display a sort of "description" field visually same as the title. Keeping always the DVC name + a new editable field. Just thinking in loud. WDYT?

maxagin avatar Jul 19 '22 00:07 maxagin

We should try to avoid having too different layouts / names between the extension and the dvc exp show. If I see the names I kinda expect to have them in CLI as well.

shcheklein avatar Jul 19 '22 01:07 shcheklein

If I see the names I kinda expect to have them in CLI as well.

Sure. EXP description - a new field for CLI. It is just for GUI will appear instead of the title. WDYT?

Sorry, it is my bad. I hope we will have the description one day, so it is better to change the name of the exp I think.

maxagin avatar Jul 19 '22 03:07 maxagin

Sure. EXP description - a new field for CLI.

I'm not sure I understand this tbh.

shcheklein avatar Jul 19 '22 04:07 shcheklein

Good idea. The problem is that names are provided and stored in DVC. @dberenbaum @pmrowla is there a way to change them after / where do we store them now?

There's no existing command (see https://github.com/iterative/dvc/issues/6667), but I think it would be helpful, and I doubt it's hard to implement since it should be possible by adding/removing git refs. cc @karajan1001

dberenbaum avatar Jul 19 '22 14:07 dberenbaum

Good idea. The problem is that names are provided and stored in DVC. @dberenbaum @pmrowla is there a way to change them after / where do we store them now?

There's no existing command (see iterative/dvc#6667), but I think it would be helpful, and I doubt it's hard to implement since it should be possible by adding/removing git refs. cc @karajan1001

I think it's not very hard to implement, but still need some time to finish it.

karajan1001 avatar Jul 21 '22 08:07 karajan1001

Closing this in favor of #2457

shcheklein avatar Oct 16 '22 18:10 shcheklein