vscode-dvc icon indicating copy to clipboard operation
vscode-dvc copied to clipboard

Date for branch, time for exp rows

Open maxagin opened this issue 3 years ago • 11 comments

DVC has date only for the branch, the expS have the time. Why can not we do the same?

Screen Shot 2022-07-15 at 11 26 29 PM

maxagin avatar Jul 16 '22 03:07 maxagin

Max, sorry, closing this since it's not actionable . What do those dates mean? What do we actually want from those dates (what problem do they solve?), etc - the ticket ideally should be described like that. Please feel free to reopen if you are able to provide more context / information to this.

shcheklein avatar Jul 16 '22 16:07 shcheklein

@shcheklein , the screenshot in the description is from DVC (or I am wrong?). My question is why does DVC have it one way and VSCode, another way? That is it. Thanks

maxagin avatar Jul 18 '22 22:07 maxagin

@maxagin yep, my point I guess is for this ticket to be more or less actionable - let's ask the DVC, put together some description, some logic behind it, etc. I would make it easier to say if it makes sense or not.

shcheklein avatar Jul 18 '22 23:07 shcheklein

Should be combined with #1444

mattseddon avatar Jul 19 '22 01:07 mattseddon

and https://github.com/iterative/vscode-dvc/issues/2031

mattseddon avatar Jul 19 '22 01:07 mattseddon

@maxagin yep, my point I guess is for this ticket to be more or less actionable - let's ask the DVC, put together some description, some logic behind it, etc. I would make it easier to say if it makes sense or not.

Hello @dberenbaum , would you be so kind to clarify for us the logic behind the information on the screenshot in the description of this ticket? Thank you Dave!

maxagin avatar Jul 19 '22 02:07 maxagin

While I don't remember conversations about the format, I believe the rationale was to show times for today's experiments since they are the most recent and important to compare at a granular level, while the exact time of each experiment is not as important for older experiments.

dberenbaum avatar Jul 19 '22 14:07 dberenbaum

Thank you Dave for the clarification!

maxagin avatar Jul 19 '22 17:07 maxagin

Show times for today's experiments since they are the most recent and important to compare at a granular level

@dberenbaum how does actually the time will help to compare EXPs (or checkpoints)? Maybe users will more likely be interested to know the range of time one run took?

Q: Do the checkpoints of one EXP, can have different dates?

maxagin avatar Jul 19 '22 22:07 maxagin

@dberenbaum how does actually the time will help to compare EXPs (or checkpoints)?

It doesn't help compare them, but it sometimes helps organize them. Seeing that this experiment was run a week ago might help me remember something about it or see quickly that it's not part of my current set of experiments. It's less important for different times on the same day, but it still helps me see the order in which I ran the experiments, which can help organize them in my mind at least.

Maybe users will more likely be interested to know the range of time one run took?

Yes, the time it took to run an experiment could be helpful. We have discussed adding that to DVC (https://github.com/iterative/dvc/discussions/7160) but right now there's no functionality to provide that info.

dberenbaum avatar Jul 20 '22 14:07 dberenbaum

Sounds good @dberenbaum ! Thank you.

maxagin avatar Jul 20 '22 19:07 maxagin

Closing this since it's not important at the moment.

shcheklein avatar Oct 16 '22 18:10 shcheklein