vscode-dvc icon indicating copy to clipboard operation
vscode-dvc copied to clipboard

Prevent text from highlighting while resizing columns

Open maxagin opened this issue 3 years ago • 5 comments

Can we disable some styles when resizing the columns? and for similar cases: when the user works with something, other info blocks should not be affected.

Please think about similar cases and list them below. Thanks, folks!

https://user-images.githubusercontent.com/98249521/177383836-44d796ab-fe34-4a7e-a785-a3ed8ce44675.mov

maxagin avatar Jul 15 '22 00:07 maxagin

@rogermparent I remember we were discussing this? Do we have a ticket for this by chance?

shcheklein avatar Jul 15 '22 02:07 shcheklein

You're right that we talked about it, but I couldn't find a ticket nor an item in any of the recent exp table stories

rogermparent avatar Jul 21 '22 17:07 rogermparent

Regarding the title, I think the solution to this specific problem will be more in the JS side like #1723 as opposed to styling, we don't want users to have these same highlights invisibly if we can help it

rogermparent avatar Jul 21 '22 17:07 rogermparent

You're right that we talked about it, but I couldn't find a ticket nor an item in any of the recent exp table stories

This was a part of https://github.com/iterative/vscode-dvc/issues/1562 Thank you @rogermparent

maxagin avatar Jul 21 '22 20:07 maxagin

If I understand correctly the second task of #2040 ("Disable the value select option in all cells"). We simply remove the ability to select for the table and that would solve the resizing problem. I think that's fine as all cells have a copy button. All cells but the experiment name. Should we had a copy button for that cell as well? The other solution would be to disable selection only while resizing.

sroy3 avatar Aug 16 '22 13:08 sroy3

The other solution would be to disable selection only while resizing.

I think this would work just fine for now.

maxagin avatar Aug 18 '22 14:08 maxagin