vscode-dvc icon indicating copy to clipboard operation
vscode-dvc copied to clipboard

Add more info to experiment table cell tooltips

Open rogermparent opened this issue 3 years ago • 2 comments

#1366 introduced header tooltips for the Experiments table, allowing users to view the full string of a header even when cut off.

We also want tooltips on cells similarly to how Studio does it, but how many features we adopt is something we'll need to sort out.

For reference, here is each type of cell tooltip in Studio I can see on my test repo:

  • I've only ever seen Param tooltips show the value of the cell in question, but they're still formatted in a way that would allow for extra fields: image

  • Metric cells use an extra field to add a delta comparing them to the cell above. Param cells do not, even if they're numbers that theoretically could. metric number tooltip

  • Some metrics have full files associated with them, and the resulting tooltips contain even more info like URL, commit, and hash metric file tooltip

  • Special cells like Commit, Timestamp, and Message have completely different simple tooltips that are more like the header ones in design: special cell tooltip

As far as how that data translates into our project:

  • We don't currently have a way to reference the value of the prior row, but we could probably find a way to add that in if we want metric deltas.
  • I haven't even seen a file metric before, do we get the kind of info from exp show that we need to show the same info? Do we handle them at all currently? I'll have to load this project to see.

Studio tooltips also behave in different ways depending which of two ways they are invoked:

  • If the cell is hovered over for around a full second (much longer than other tooltips) the tooltip is non-interactive disappearing as soon as the mouse leaves the cell.
  • If the cell is clicked, the tooltip persistently stays up until the user clicks anywhere outside the tooltip (including the cell itself) and is interactive when clicking inside the tooltip- the "click here to copy" text is actually a clickable link that provides an alternate way to copy a cell's contents.

rogermparent avatar Mar 03 '22 22:03 rogermparent

With the recent consensus that click-to-persist cell tooltips aren't very valuable right now, #1384 fulfills a most of what this ticket requires. As far as I can tell, the remaining features we may want are:

  • [ ] Simple tooltips for Experiments/Timestamp
  • [ ] Deltas on Metrics tooltips

There's also the Data tooltips which have the most complexity in Studio, but those depend on support for data columns which I believe we don't have yet.

rogermparent avatar Mar 31 '22 22:03 rogermparent

Should be next step in #1657

mattseddon avatar Jul 22 '22 01:07 mattseddon