terraform-provider-iterative icon indicating copy to clipboard operation
terraform-provider-iterative copied to clipboard

Published 20 hours ago • verified publisher icon iterative

Update nvidia support package

Open aliabbasjaffri opened this issue 1 year ago • 3 comments

Replaced the deprecated nvidia package with the new nvidia-container-utils as mentioned in the official documentation

aliabbasjaffri avatar Oct 07 '22 07:10 aliabbasjaffri

@aliabbasjaffri, can you please update also the golden tests by running go test ./iterative -update on the project root? 🙏🏼

0x2b3bfa0 avatar Oct 07 '22 10:10 0x2b3bfa0

Sorry for asking the dumb question here, but i'm new to this. How would i update the golden tests?

aliabbasjaffri avatar Oct 07 '22 14:10 aliabbasjaffri

By running go test ./iterative -update as stated on https://github.com/iterative/terraform-provider-iterative/pull/688#issuecomment-1271417049

0x2b3bfa0 avatar Oct 07 '22 16:10 0x2b3bfa0

@0x2b3bfa0 golden tests generated and updated!

aliabbasjaffri avatar Oct 08 '22 12:10 aliabbasjaffri

Thank you very much, @aliabbasjaffri! 🙏🏼

0x2b3bfa0 avatar Oct 08 '22 15:10 0x2b3bfa0

@0x2b3bfa0 Seems like auto-merge didn't work! :(

aliabbasjaffri avatar Oct 08 '22 17:10 aliabbasjaffri

~@aliabbasjaffri if you want to reopen this PR we can do some more testing. It had to be reverted for an issue with Gitlab runners. /open a new one.~

dacbd avatar Oct 09 '22 01:10 dacbd