terraform-provider-iterative icon indicating copy to clipboard operation
terraform-provider-iterative copied to clipboard

Slight refactoring of machine script generation.

Open tasdomas opened this issue 1 year ago • 1 comments

Use embedded template instead of format string. Add test. Remove use of map pointer - golang maps are already pointers to a maps structure and can be nil.

tasdomas avatar Aug 08 '22 14:08 tasdomas

Have you considered using github.com/sebdah/goldie for template tests, like in other places of this project? E.g.

https://github.com/iterative/terraform-provider-iterative/blob/142cd5b8b1aba9b0deb746b9fc5cfe3b6fecdd39/iterative/testdata/script_template_cloud_aws.golden#L1

0x2b3bfa0 avatar Aug 08 '22 16:08 0x2b3bfa0

Merging with AWS red because of capacity issues; works as expected.

0x2b3bfa0 avatar Aug 15 '22 18:08 0x2b3bfa0