Linters?

[dacbd]

aka Restyled's PR spam triggers me...

thoughts on adding github/super-linter/slim as a check for PRs and removing Restyled.

I will note that, that the linter has a bit on a laundry list... see here

[0x2b3bfa0]

Note that we already have golangci-lint in place for the task directory. The iterative directory has been explicitly excluded because it has, effectively, a laundry list of issues.

Ma quel foglio che chiedete per azzardo m'è cascato. È la lista del bucato.

[0x2b3bfa0]

https://github.com/iterative/terraform-provider-iterative/blob/5194dc5f68c4fa07cb2d0f7304bee58f0208f5f5/.golangci.yml#L3-L4

[dacbd]

I missed that 🙈, does it work with deltas natively? Perhaps it's time to include it and as future tweaks come in part of the PRs will be cleanup.

[0x2b3bfa0]

does it work with deltas natively?

If you mean --new-from-rev yes.

[0x2b3bfa0]

Moved to https://github.com/iterative/terraform-provider-iterative/pull/616

[0x2b3bfa0]

Not sure if we need super-linter for a single language, but it's indeed a nice project. Let's ask @iterative/cml for opinions; we'll surely get plenty. 😄

[dacbd]

it also dectects various bits of shell scripting, GitHub actions, and others etc

[0x2b3bfa0]

Sounds good. Let's lint, then. 🐑

[0x2b3bfa0]

Note that running super-linter locally doesn't feel quite ergonomic. I hope we won't need to run a Docker container with a commit hook. 😈