terraform-provider-iterative icon indicating copy to clipboard operation
terraform-provider-iterative copied to clipboard

docs: `task` requirements 2

Open casperdcl opened this issue 2 years ago • 11 comments

p2

  • [x] #457
    • [x] #450
      • [x] show examples for all the task resource arguments
      • [x] Show/explain CI restart workflow lifecycle & environment propagation
      • [x] mention future plans (distributed/multi-instance, security)
  • [x] banner/logo: https://github.com/iterative/static/pull/8
  • [x] simple flowcharts/diagrams #492
  • [x] post-merge feedback from #433
  • [x] https://github.com/iterative/terraform-provider-iterative/issues/513
  • [ ] end-to-end tutorials/example repo(s) - e.g. getting credentials, using cloud = "{aws,az,gcp}", installing deps & running scripts
    • see e.g. https://github.com/kubeflow/examples/blob/master/named_entity_recognition/documentation/step-1-setup.md?
  • [x] improve formatting of table at docs/guides/generic-machine-types #532
  • [ ] consider collapsing machine-type, machine-image and cloud-region sections in <details>
  • [ ] add or link to ML-related examples
  • [ ] what other common use-cases should be mentioned (e.g. install awscli & upload artefacts to a bucket)?
  • [ ] maybe link to terraform help (https://learn.hashicorp.com/tutorials/terraform/aws-build?)
  • [ ] README vs registry (à la dvc.org#2443)
    • [x] readme says "terminate compute instances upon job completion/failure." Should say this in "Run Task" & also in registry #532
    • [ ] misc feedback #558

p1

casperdcl avatar Jan 12 '22 14:01 casperdcl

what permissions are required (e.g. port 22 open)?

This is needed for runner. task is not enforced right now to use ssh, we use the cloud storage

DavidGOrtega avatar Jan 13 '22 11:01 DavidGOrtega

This are my pics @casperdcl

As far as I see you already have some

README

Automatically destroy unused cloud resources (never forget to turn your GPU off again)

This is not true at current status unless you use runner

TERRAFORM DOCS

  • [ ] Why generic machine types are in Development section?
  • [ ] Missing specific cloud permissions
  • [ ] Missing complete spot instances survival lifecycle (which is the best effort in tgi)
  • [ ] CI restart workflow lifecicle and explain also the environment propagation

Create a directory named shared to store input data and output artefacts.

I do not fully undestand this example. Why should the user modify the project structure? If someone is telling me to modify my project to use a tool I would say... F*#$@ U

The script argument can take any string, including a heredoc or the contents of a file returned by the file function.

Is better if we setup an example instead (terraform docs are not great). Also is very nice the idea of using python scripting as an example

Status and events don't produce a stable output between cloud providers and are intended for human consumption only.

Right now the status is normalised

DavidGOrtega avatar Feb 15 '22 14:02 DavidGOrtega

This is not true at current status unless you use runner[citation needed]

As far as I can tell, iterative_task terminates all the instances as soon as the script finishes running. 🤔

0x2b3bfa0 avatar Feb 15 '22 16:02 0x2b3bfa0

Add to the list https://github.com/iterative/terraform-provider-iterative/issues/258#issuecomment-977180443, “add a documentation footnote that after the task completes its instance is auto destroyed”

0x2b3bfa0 avatar Feb 15 '22 16:02 0x2b3bfa0

Added an item to ~the p1 checklist here~ #397 instead :)

casperdcl avatar Feb 15 '22 17:02 casperdcl

@casperdcl can you please add these two?

  • [ ] Complete spot instances survival lifecycle (which is the best effort in tpi)
  • [ ] CI restart workflow lifecycle and explain also the environment propagation

DavidGOrtega avatar Feb 17 '22 09:02 DavidGOrtega

@casperdcl - suggest to add here the fix to the banner being broken here Missing banner-terraform.png

omesser avatar Mar 29 '22 15:03 omesser

thx added to #450 :)

casperdcl avatar Mar 29 '22 15:03 casperdcl

Don't forget this pearl:

  • https://github.com/iterative/terraform-provider-iterative/issues/457#issuecomment-1076551061

    curl https://github.com/$GITHUB_ACTOR.keys >> $HOME/.ssh/authorized_keys
    

0x2b3bfa0 avatar Apr 19 '22 10:04 0x2b3bfa0

Already done https://registry.terraform.io/providers/iterative/iterative/latest/docs/guides/getting-started#debugging

casperdcl avatar Apr 19 '22 13:04 casperdcl

🙈 The sad part is that I reviewed that change.

0x2b3bfa0 avatar Apr 19 '22 13:04 0x2b3bfa0