mlem icon indicating copy to clipboard operation
mlem copied to clipboard

Requirement version resolution fix

Open omesser opened this issue 2 years ago • 3 comments

Use importlib.metadata's distribution to extract package versions closes: https://github.com/iterative/mlem/issues/688

omesser avatar Jul 13 '23 20:07 omesser

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.07% :warning:

Comparison is base (f2a5847) 82.71% compared to head (2059f21) 82.64%. Report is 2 commits behind head on main.

:exclamation: Current head 2059f21 differs from pull request most recent head 02232ca. Consider uploading reports for the commit 02232ca to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #694      +/-   ##
==========================================
- Coverage   82.71%   82.64%   -0.07%     
==========================================
  Files         109      109              
  Lines        9943     9948       +5     
==========================================
- Hits         8224     8222       -2     
- Misses       1719     1726       +7     
Files Changed Coverage Δ
mlem/core/hooks.py 95.08% <ø> (ø)
mlem/utils/module.py 90.00% <50.00%> (-2.21%) :arrow_down:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 31 '23 14:07 codecov[bot]

I forgot about this for a few weeks but came back to this today and fixed the tests, with intention of merging this and releasing to fix #688

omesser avatar Jul 31 '23 16:07 omesser

Seems that CI is broken (not related to changes here, see example in this test PR) Will need to look at it separately and come back to this afterwards

omesser avatar Aug 24 '23 02:08 omesser