mlem icon indicating copy to clipboard operation
mlem copied to clipboard

add meta flag to load

Open mike0sv opened this issue 2 years ago • 3 comments

mike0sv avatar May 27 '22 13:05 mike0sv

@aguschin @madhur-tandon I did this a while ago. Do we need this WDYT?

mike0sv avatar May 27 '22 13:05 mike0sv

@omesser do you think we need this? We are 50/50. We have load_meta(...) that's going to be the same as load(..., as_meta=True)

aguschin avatar May 30 '22 11:05 aguschin

Generally speaking I think we shouldn't have 2 ways to do the same thing. So either load_meta() OR load(..., as_meta=True) no need for both, unless some specific restrictions require this.

Some questions to give me background:

  1. Would the user be interested in interacting with the MlemObject directly? what are the benefits?
  2. Why is "MlemObject" called "meta" in user facing flags/methods and not mlem_object (so: load_mlem_object, as_mlem_object)?
  3. If there's an existing load_meta() - why isn't load() using it today (duplicated logic?)

omesser avatar Jul 15 '22 14:07 omesser

closing as outdated

mike0sv avatar Sep 05 '22 19:09 mike0sv