dvc icon indicating copy to clipboard operation
dvc copied to clipboard

vscode: support flexible plots

Open pared opened this issue 3 years ago • 3 comments

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

Change required for iterative/vscode-dvc#2379 Related iterative/vscode-dvc#1757

pared avatar Sep 12 '22 09:09 pared

@pared This seems to break bar plots at the moment. The values in the HTML are missing rev and formatted like:

    {
        "Feature": "data frame",
        "Mean decrease in impurity": "0.10044235196789414",
        "dvc_data_version_info": {
            "field": "Feature",
            "filename": "feature_importance.csv",
            "revision": "exp-fe059"
        }

dberenbaum avatar Sep 15 '22 14:09 dberenbaum

@dberenbaum yep, hence the WIP, but I am not sure yet if we want to merge it, as I see that vscode team can handle that support even with existing DVC. Let's wait how the vscode implementation progresses, I can fix the tests when needed.

pared avatar Sep 16 '22 10:09 pared

Ok, as I see in https://github.com/iterative/vscode-dvc/issues/1757#issuecomment-1250230807 we do rely on it. I will update this PR

pared avatar Sep 19 '22 11:09 pared

Minor comments. If it works for VSCode, lgtm

Everything seems to be working on our end 👍🏻.

image

mattseddon avatar Sep 23 '22 00:09 mattseddon