dvc icon indicating copy to clipboard operation
dvc copied to clipboard

dvcignore: read ignore patterns from global .dvcignore

Open meshde opened this issue 3 years ago • 4 comments

Read the patterns from system-level .dvcignore (~/.dvcignore) and include these as part of the default ignore pattern used while initiating the ignore trie

Fixes #8261

meshde avatar Sep 11 '22 03:09 meshde

LGTM, except for the question discussed above. Still need an update on the doc side.

karajan1001 avatar Sep 13 '22 07:09 karajan1001

Still need an update on the doc side.

@karajan1001 thank you for the review!

Just raised a PR to update the docs here: https://github.com/iterative/dvc.org/pull/3950

meshde avatar Sep 15 '22 09:09 meshde

@pmrowla @dtrifiro just updated the code based on your comments.

lmk what you think of these changes.

meshde avatar Sep 15 '22 09:09 meshde

I'm not sure what's up with the failing Lint check and I'm not able to reproduce it locally.

Any help in resolving that would be highly appreciated 😄

meshde avatar Sep 18 '22 16:09 meshde

@dtrifiro updated the PR as per your suggestions.

Lmk what you think now.

meshde avatar Sep 30 '22 03:09 meshde

@meshde @iterative/dvc any progress here folks?

shcheklein avatar Dec 21 '22 17:12 shcheklein

Closing as stale. Please feel free to reopen if you'll find time to address https://github.com/iterative/dvc/pull/8280#discussion_r987781992 This change is useful, but we don't have the capacity to take it over ourselves right now.

efiop avatar Jan 09 '23 00:01 efiop