dvc
dvc copied to clipboard
iterative
`exp run --set-param`: Doesn't support `-` in param name
Introduced in #8067
Appears to be a Hydra limitation that the author doesn't plan to address:
https://github.com/facebookresearch/hydra/issues/514
My reading of the author's concerns appear to be limited to using -- preceding a parameter name, not use of - anywhere in the parameter name. Are you reading it differently?
My reading of the author's concerns appear to be limited to using
--preceding a parameter name, not use of-anywhere in the parameter name. Are you reading it differently?
I guess the thing is that the restriction of - is currently embedded in the grammar rules, no matter where it is used.
Allowing - in some cases but not in others would require new rules.
We could explain our use case and see if it makes a difference, as we are using internals directly, or ask if there is an alternative for us.
I ran into same problem while trying to queue experiments with --set-param options. The binaries in my DVC pipeline use many --some-argument-name style arguments, which work great with DVC's dict unpacking and YAML's support for keys that contain -.
It would be great if --set-param would support these as well.
@daavoo What do you think about adding this to the backlog since it is a regression in DVC?
@daavoo What do you think about adding this to the backlog since it is a regression in DVC?
I assume you mean patching on our side, right?
No, I meant contributing to hydra 😄 , but patching on our side is also fine.
No, I meant contributing to hydra 😄 , but patching on our side is also fine.
I just felt that https://github.com/facebookresearch/hydra/pull/2094 is pretty much done and would fix this issue. I don't see any comment requiring changes, it looks blocked pending the resolution of the discussion so not sure what we could contribute
Got it. Let's follow in https://github.com/facebookresearch/hydra/issues/2363. Again, no problem with patching on our side for now if that's going to be quicker/easier.
With hydra v1.3.0 it works properly here.
λ dvc version
DVC version: 2.36.0 (pip)
