dvc icon indicating copy to clipboard operation
dvc copied to clipboard

Published 20 hours ago • verified publisher icon iterative

plots: Expand flexible plots tests

Open daavoo opened this issue 3 years ago • 3 comments

Yes, its true. I will fix that in follow up PR, where I intend to parameterized this test to handle one use case per test. That way we won't have to create this huge repo_with_plots. This specific use case (list of columns) is tested in tests/unit/render/test_vega_converter.py::test_converter - its a unit test but should be enough for now.

Originally posted by @pared in https://github.com/iterative/dvc/pull/7477#discussion_r910856251

daavoo avatar Jun 30 '22 15:06 daavoo

Aim of this issue is to parametrize tests in tests/integration/plots/test_plots.py, so that we have single use case per parameter set, and not testing few use cases at once, as we do now. That will allow us to test every expected plots set up with a test that is much easier to comprehend.

pared avatar Jul 01 '22 08:07 pared

Need to test #8004 too

pared avatar Jul 11 '22 22:07 pared

Include test for #8159

pared avatar Aug 23 '22 10:08 pared

@daavoo What's still needed here?

dberenbaum avatar Mar 16 '23 15:03 dberenbaum

@daavoo What's still needed here?

No idea off the top of my mind. I would need to take a look. At this point, I think most behaviors we care about are somehow tested in here or dvc-render or studio. But revisiting the tests would not hurt

daavoo avatar Mar 16 '23 15:03 daavoo

Okay, feel free to close this one or take another look.

dberenbaum avatar Mar 16 '23 16:03 dberenbaum