checkout/pull: dvcignored contents are removed on checkout

[skshetry]

cd "$(mktemp -d)"
dvc init --no-scm
dvc remote add -d local "$(mktemp -d)"
mkdir -p data/processed
echo "foo" > data/foo
echo "bar" > data/processed/bar
echo "data/processed/" >> .dvcignore
dvc add data
dvc push
rm -rf .dvc/cache data/foo
dvc pull | tee

This is a regression introduced in b349b39d6266a28705b03b1b06e5c0cf98a9080d (see #5812), which was released in 2.2.0 and is present since then.

[skshetry]

#4344 and this issue are related to staging in dvc-data.

[karajan1001]

PR #7963 partly solve this problem (for the pull and checkout after a ststus ). To completely close this required some following work on dvc_data side.

[daavoo]

To completely close this required some following work on dvc_data side.

@karajan1001 do you recall what is missing?

[karajan1001]

To completely close this required some following work on dvc_data side.

@karajan1001 do you recall what is missing?

Sorry, I forgot about it.

[skshetry]

Looks like this has been fixed at some point. Closing.