dvc icon indicating copy to clipboard operation
dvc copied to clipboard

check-ignore: stabilize behavior for subrepos

Open efiop opened this issue 4 years ago • 5 comments

git chec-ignore will error-out if you try to use a path that is in submodule. Seems like dvc check-ignore should do the same with our subrepos.

See https://github.com/iterative/dvc/pull/6000#discussion_r631438598

efiop avatar May 13 '21 01:05 efiop

image

git check-ignore didn't error out but showed null on my computer. But still different than dvc check-ignore

karajan1001 avatar May 14 '21 09:05 karajan1001

@karajan1001 is subrepo a git submodule?

efiop avatar May 14 '21 09:05 efiop

@karajan1001 is subrepo a git submodule?

Both Git and DVC.

karajan1001 avatar May 14 '21 09:05 karajan1001

image OK, I know I didn't commit it.

karajan1001 avatar May 14 '21 09:05 karajan1001

fatal: ../a.dvc: '../a.dvc' is outside repository at '/Users/gao/Code/test/subrepo/subrepo'

Same condition on files outside repo.

karajan1001 avatar May 17 '21 01:05 karajan1001