dvc icon indicating copy to clipboard operation
dvc copied to clipboard

progress: push and pull: single bytes-based bar

Open casperdcl opened this issue 5 years ago • 4 comments

  • one progress bar only (based on file sizes, fallback to number of files in sizes not available)
  • may also retain nested bars just for large/long running individual files

Would use status framework to get files sizes for creation of bar with expected total for a full progress bar with ETA to be displayed.

casperdcl avatar Apr 25 '20 15:04 casperdcl

This is something that I am interested to work on, for the UI changes soon. For this, we may need events/callback changes in the internals, and a better component to display files/bytes at the same time (does tqdm support that?).

It'd also be nice to have some way to get both files/sizes through RepoFileSystem so that we could also have similar behaviour on the import/get/update.

cc @dberenbaum

skshetry avatar Jul 22 '21 15:07 skshetry

and a better component to display files/bytes at the same time (does tqdm support that?).

what do you mean? as in show both files/s and bytes/s simultaneously but have the bar only correspond to one of them (i.e files % or bytes %)?

casperdcl avatar Jul 22 '21 15:07 casperdcl

@casperdcl, more than tqdm supporting right now, what do you think having multiple things to update to fits in the tqdm?

I was mostly trying to avoid writing our custom renderer as much as possible, so I was experimenting with this unified progress bars/counters concept in https://github.com/iterative/dvc/pull/6304 with lots of postfix hacks and Task from rich where the logic for the files/s etc is nicely separated from the UI part of it.

Most likely, if we go to the route of #6304 like component, we may need to write our own.

skshetry avatar Jul 22 '21 15:07 skshetry

@skshetry Is this one completed?

dberenbaum avatar Jul 08 '22 20:07 dberenbaum