dvc icon indicating copy to clipboard operation
dvc copied to clipboard

studio: add subdir to live metrics post messages to support live experiments in monorepos

Open mattseddon opened this issue 1 year ago • 2 comments

Thank you for the contribution - we'll try to review it as soon as possible. 🙏


Part of https://github.com/iterative/studio/issues/8848

Depends on https://github.com/iterative/dvc-studio-client/pull/154 / https://github.com/iterative/studio/pull/9173

Required by https://github.com/iterative/dvclive/pull/787

Repeat of https://github.com/iterative/dvc/pull/10291 but stripped back to only send subdir.

mattseddon avatar Feb 15 '24 08:02 mattseddon

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c72e1fb) 90.58% compared to head (687b06d) 90.59%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10303   +/-   ##
=======================================
  Coverage   90.58%   90.59%           
=======================================
  Files         493      493           
  Lines       37757    37774   +17     
  Branches     5454     5460    +6     
=======================================
+ Hits        34204    34221   +17     
  Misses       2919     2919           
  Partials      634      634           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 15 '24 08:02 codecov[bot]

Currently needs a Studio release

mattseddon avatar Feb 16 '24 02:02 mattseddon

@dberenbaum can you PTAL at this now Studio has been released

mattseddon avatar Feb 20 '24 19:02 mattseddon

Should we add a test to https://github.com/iterative/dvc/blob/main/tests/integration/test_studio_live_experiments.py to ensure the subdir is sent to studio?

dberenbaum avatar Feb 20 '24 19:02 dberenbaum

Should we add a test to https://github.com/iterative/dvc/blob/main/tests/integration/test_studio_live_experiments.py to ensure the subdir is sent to studio?

I felt like the complexity that needed to be tested was addressed by test_monorepo_relpath but I have added test_post_to_studio_subdir (Hopefully it passes on Windows)

mattseddon avatar Feb 20 '24 21:02 mattseddon