dvc.org icon indicating copy to clipboard operation
dvc.org copied to clipboard

make_checkpoint: rewrite code for every100th iterations

Open skshetry opened this issue 3 years ago • 1 comments

IANADS so any help on improving this code/docs would be great.

skshetry avatar Sep 22 '22 04:09 skshetry

6b3f209

Link Check Report

There were no links to check!

CML watermark

github-actions[bot] avatar Sep 22 '22 04:09 github-actions[bot]

My overall take here: I don't have a strong opinion on whether to merge this. It's a more realistic example, but the original example was simplistic on purpose to clarify how it works.

IMO it would be better to focus on improving checkpoints functionality before worrying too much about improving the docs. See https://github.com/iterative/dvc/issues/7381.

dberenbaum avatar Sep 22 '22 12:09 dberenbaum

but the original example was simplistic on purpose to clarify how it works.

I disagree that it was simplistic because of all the reading/writing stuff it is doing, which is confusing. Also, it's 22 lines of code.

skshetry avatar Sep 22 '22 13:09 skshetry