dvc.org icon indicating copy to clipboard operation
dvc.org copied to clipboard

prism: new or expanded DVC highlighter for Windows

Open jorgeorpinel opened this issue 3 years ago • 4 comments

do a proper dvc highlighter that supports Windows (Command Prompt format, similar to Prism powershell)

Originally posted by @shcheklein in https://github.com/iterative/dvc.org/pull/3273#discussion_r805091274

jorgeorpinel avatar Feb 12 '22 03:02 jorgeorpinel

Cc @iterative/websites

jorgeorpinel avatar Feb 12 '22 03:02 jorgeorpinel

This is effectively just $ vs >, right?

casperdcl avatar Feb 16 '22 17:02 casperdcl

his is effectively just $ vs >, right?

Possibly. Depends if we want to use powershell commands in some of our code blocks. Our dvc highlighter extends on bash and doesn't highlight windows commands properly. If we want to use powershell commands, then we'd need to create or extend our dvc highlighter to work with powershell, not just bash. But if we just want to focus our code blocks on just using commands that work on both bash and powershell, we can probably just update our dvc highlighter to just check for $ or > in the beginning of a line.

julieg18 avatar Feb 16 '22 17:02 julieg18

update our dvc highlighter to just check for $ or > in the beginning of a line

It's a start.

jorgeorpinel avatar Feb 22 '22 16:02 jorgeorpinel