cml icon indicating copy to clipboard operation
cml copied to clipboard

Support for notebooks diff

Open dmpetrov opened this issue 5 years ago • 4 comments

A user asked for reviewnb support. Further investigation is needed.

dmpetrov avatar Jul 11 '20 00:07 dmpetrov

I bit more context. I'm not 100% sure we need to support reviewing (it looks like it is proprietary). What we actually need - to understand Jupiter user's workflow better and solve some of the issues in the CI part. Any ideas are welcome!

dmpetrov avatar Jul 14 '20 17:07 dmpetrov

Note - take a look at:

  1. https://github.com/nteract/papermill - parametrize notebooks
  2. https://github.com/jupyter/nbdime - diff and merge notebooks

dmpetrov avatar Jul 15 '20 14:07 dmpetrov

https://github.com/jupyter/nbdime - diff and merge notebooks

Thats the tool we are currently evaluating 😃

DavidGOrtega avatar Jul 15 '20 15:07 DavidGOrtega

Can this be closed?

pip install nbdime
echo '```diff' >> report.md
nbdiff <old_sha> <new_sha> <file.ipynb> >> report.md
echo '```' >> report.md
cml send-comment report.md

Not sure if @iterative/studio wants to render nbdiff-web output though?

casperdcl avatar Sep 05 '22 18:09 casperdcl