cml icon indicating copy to clipboard operation
cml copied to clipboard

workflow: dogfood & tidy

Open casperdcl opened this issue 3 years ago • 5 comments

  • minify/tidy/lint workflows
  • bump actions versions
  • CML dogfooding
  • make releases --draft

casperdcl avatar Sep 12 '22 22:09 casperdcl

I am personally not a fan of the {} syntax

I wholeheartedly agree: it's :purugly:

0x2b3bfa0 avatar Sep 12 '22 23:09 0x2b3bfa0

personally not a fan of the {} syntax

-Wnot-using-a-legitimate-feature? This syntax exists for precisely this use case (short one-liner unlikely to change).

less commonly seen in the scope of GitHub Actions

fallacious, scanadlous!

casperdcl avatar Sep 13 '22 10:09 casperdcl

-Wnot-using-a-legitimate-feature

For the same reason some code files contain line breaks, even if they don't have to: readability.

0x2b3bfa0 avatar Sep 13 '22 11:09 0x2b3bfa0

For the same reason some code files contain line breaks

Still not right - an accurate analogy would be refusing to use line breaks. Refusing to use a feature regardless of scenario is inexplicable.

readability

yes, maximising that here. Also not using {} where it doesn't make sense/harms readability. Also the linter is v. happy with the proposed use of {} :)

casperdcl avatar Sep 14 '22 19:09 casperdcl

Re {} - that syntax has limited (very limited) uses in yaml, imho. Linters are not raising issues because valid json is valid yaml.

tasdomas avatar Sep 16 '22 14:09 tasdomas

dropped {} by popular demand

~Also pushed some docstring edits after a thorough review (related to https://github.com/iterative/cml.dev/pull/324) - please do check /CC @0x2b3bfa0~ will move to separate PR

casperdcl avatar Sep 22 '22 12:09 casperdcl