cml.dev icon indicating copy to clipboard operation
cml.dev copied to clipboard

replace all sklearn -> scikit-learn

Open casperdcl opened this issue 3 years ago • 3 comments

Quite a few instances in https://github.com/search?l=Text&q=org%3Aiterative+sklearn&type=Code

See e.g. https://github.com/iterative/example_cml/pull/256, https://github.com/iterative/cml_dvc_case/pull/23

casperdcl avatar Sep 26 '22 18:09 casperdcl

Is there really a supply chain issue here? sklearn is a dummy package that specifies scikit-learn as its only dependency. Sure, it's just a workaround for the import and package name mismatch in scikit-learn, but apart from the additional sklearn==0.0 line in the output of pip freeze there's no significant issue.

tasdomas avatar Sep 27 '22 13:09 tasdomas

shot in the dark, but there have been a few issues of users asking for support on discord that has stemmed from pip install issues and sk[scikit-]learn versions, so if this is related to that :+1:

dacbd avatar Sep 27 '22 14:09 dacbd

yes, we should fix it since it looks like the dummy package doesn't always install properly

casperdcl avatar Oct 03 '22 11:10 casperdcl