itch icon indicating copy to clipboard operation
itch copied to clipboard

🐧 Feedback v25.4.9-canary

Open TheGamer1002 opened this issue 4 years ago • 3 comments

Event log:

TypeError: Cannot read property 'length' of undefined

Crashed after selecting "explore" tab. Note: no content was shown on the "owned" area, but I do not know if this is standard behavior.

EDIT: Still present after fresh clone of the repo, except it now happens after about 2 seconds on the home screen.

Using Xubuntu 20.10 x86_64 amd64

Full log:

$ ~/itch (master)> npm start

> [email protected] start /home/user/itch
> node develop.js

⬡ develop: Main building...
ℹ 「wds」: Project is running at http://localhost:9000/
ℹ 「wds」: webpack output is served from undefined
ℹ 「wds」: Content not from webpack is served from /home/user/itch
⬡ develop: Main built!
⬡ develop: Renderer building...
⬡ develop: Will start app with /home/user/itch/node_modules/electron/dist/electron
⬡ develop: ...off content on localhost:9000
⬡ develop: Should've started the app now...
Debugger listening on ws://127.0.0.1:9222/1e5a2e5f-f4b3-4d5d-837c-38291eb53e6b
For help, see: https://nodejs.org/en/docs/inspector
18:26:26.141 INFO [email protected] on [email protected] in development
18:26:26.143 DEBUG (m/reac/preb/load-preferences) imported preferences: {"downloadSelfUpdates":true,"offlineMode":false,"installLocations":{},"defaultInstallLocation":"appdata","isolateApps":false,"closeToTray":true,"readyNotification":true,"showAdvanced":false,"openAtLogin":false,"openAsHidden":false,"manualGameUpdates":false,"preventDisplaySleep":true,"preferOptimizedPatches":false,"disableBrowser":false,"enableTabs":false,"importedOldInstallLocations":true}
Gtk-Message: 13:26:26.271: Failed to load module "appmenu-gtk-module"
ℹ 「wdm」: Hash: f93f889eab2398ac614e
Version: webpack 4.46.0
Time: 20696ms
Built at: 02/22/2021 1:26:26 PM
                                 Asset      Size    Chunks                         Chunk Names
                            0.chunk.js   164 KiB         0  [emitted]              
                            1.chunk.js  30.8 KiB         1  [emitted]              
                           10.chunk.js  76.8 KiB        10  [emitted]              
                           11.chunk.js  49.6 KiB        11  [emitted]              
                           12.chunk.js  63.7 KiB        12  [emitted]              
                           13.chunk.js  77.1 KiB        13  [emitted]              
                           14.chunk.js  63.8 KiB        14  [emitted]              
                           15.chunk.js    49 KiB        15  [emitted]              
                           16.chunk.js    52 KiB        16  [emitted]              
                           17.chunk.js  78.5 KiB        17  [emitted]              
                           18.chunk.js  49.7 KiB        18  [emitted]              
                           19.chunk.js  38.2 KiB        19  [emitted]              
                            2.chunk.js  24.6 KiB         2  [emitted]              
                           20.chunk.js  27.5 KiB        20  [emitted]              
                           21.chunk.js  25.8 KiB        21  [emitted]              
                           22.chunk.js  38.3 KiB        22  [emitted]              
                           23.chunk.js    16 KiB        23  [emitted]              
                           24.chunk.js  33.3 KiB        24  [emitted]              
                           25.chunk.js  30.2 KiB        25  [emitted]              
                           26.chunk.js  23.6 KiB        26  [emitted]              
                           27.chunk.js  26.2 KiB        27  [emitted]              
                           28.chunk.js  22.5 KiB        28  [emitted]              
                           29.chunk.js  15.7 KiB        29  [emitted]              
                            3.chunk.js  24.5 KiB         3  [emitted]              
                           30.chunk.js  24.4 KiB        30  [emitted]              
                           31.chunk.js    21 KiB        31  [emitted]              
                           32.chunk.js  21.1 KiB        32  [emitted]              
                           33.chunk.js  11.4 KiB        33  [emitted]              
                           34.chunk.js  9.82 KiB        34  [emitted]              
                           35.chunk.js  8.87 KiB        35  [emitted]              
                           36.chunk.js  11.5 KiB        36  [emitted]              
                           37.chunk.js  3.55 KiB        37  [emitted]              
                           38.chunk.js  8.67 KiB        38  [emitted]              
                           39.chunk.js  5.43 KiB        39  [emitted]              
                            4.chunk.js  47.6 KiB         4  [emitted]              
                           40.chunk.js  4.14 KiB        40  [emitted]              
                           41.chunk.js  1.12 KiB        41  [emitted]              
                           42.chunk.js  2.02 KiB        42  [emitted]              
                           43.chunk.js  3.79 KiB        43  [emitted]              
                           44.chunk.js  2.68 KiB        44  [emitted]              
                           45.chunk.js  33.1 KiB        45  [emitted]              
  45416ee3387c41c6a09090e575792a09.svg   5.1 KiB            [emitted] [immutable]  
4572f9353693b74961c1cde112327537.woff2   226 KiB            [emitted] [immutable]  
48af781eee377a05e18fac717e38cb80.woff2   252 KiB            [emitted] [immutable]  
4c1ce87cd8b8a2560310476c53a0f522.woff2   228 KiB            [emitted] [immutable]  
                            5.chunk.js  29.4 KiB         5  [emitted]              
                            6.chunk.js   138 KiB         6  [emitted]              
 6d6659b1d54be37db4744f0a86991dba.woff    22 KiB            [emitted] [immutable]  
                            7.chunk.js  91.5 KiB         7  [emitted]              
                            8.chunk.js  66.6 KiB         8  [emitted]              
                            9.chunk.js  55.4 KiB         9  [emitted]              
  c143903d0c758898b2428036ce9061e6.svg  3.04 KiB            [emitted] [immutable]  
cfddb30cb792c86f78d4881a09c61bb3.woff2   222 KiB            [emitted] [immutable]  
d23c23e401fd3e9697e74afbb8a8431a.woff2   253 KiB            [emitted] [immutable]  
d884bc5d2f53044df1580cb549d99bda.woff2   251 KiB            [emitted] [immutable]  
f068dc9a0ef09bd07dfec4398a47bbb9.woff2   227 KiB            [emitted] [immutable]  
fbaa441269a0c4dc3a81fef44e8402f8.woff2   250 KiB            [emitted] [immutable]  
                            index.html  1.11 KiB            [emitted]              
                    renderer.bundle.js  3.58 MiB  renderer  [emitted]              renderer
Entrypoint renderer = renderer.bundle.js
[0] multi (webpack)-dev-server/client?http://localhost (webpack)/hot/dev-server.js ./src/renderer/index.tsx 52 bytes {renderer} [built]
[./node_modules/bluebird/js/browser/bluebird.js] 179 KiB {renderer} [built]
[./node_modules/react-dom/index.js] 1.33 KiB {renderer} [built]
[./node_modules/react-hot-loader/index.js] 1.55 KiB {renderer} [optional] [built]
[./node_modules/react-hot-loader/patch.js] 229 bytes {renderer} [built]
[./node_modules/react-redux/es/index.js] 776 bytes {renderer} [built]
[./node_modules/react/index.js] 190 bytes {renderer} [built]
[./node_modules/webpack-dev-server/client/index.js?http://localhost] (webpack)-dev-server/client?http://localhost 4.29 KiB {renderer} [built]
[./node_modules/webpack-dev-server/client/overlay.js] (webpack)-dev-server/client/overlay.js 3.51 KiB {renderer} [built]
[./node_modules/webpack-dev-server/client/socket.js] (webpack)-dev-server/client/socket.js 1.53 KiB {renderer} [built]
[./node_modules/webpack-dev-server/client/utils/createSocketUrl.js] (webpack)-dev-server/client/utils/createSocketUrl.js 2.91 KiB {renderer} [built]
[./node_modules/webpack-dev-server/client/utils/log.js] (webpack)-dev-server/client/utils/log.js 964 bytes {renderer} [built]
[./node_modules/webpack-dev-server/client/utils/reloadApp.js] (webpack)-dev-server/client/utils/reloadApp.js 1.59 KiB {renderer} [built]
[./node_modules/webpack/hot/dev-server.js] (webpack)/hot/dev-server.js 1.59 KiB {renderer} [built]
[./src/renderer/index.tsx] 2.63 KiB {renderer} [built]
    + 870 hidden modules
Child HtmlWebpackCompiler:
                          Asset      Size               Chunks  Chunk Names
    __child-HtmlWebpackPlugin_0  5.65 KiB  HtmlWebpackPlugin_0  HtmlWebpackPlugin_0
    Entrypoint HtmlWebpackPlugin_0 = __child-HtmlWebpackPlugin_0
    [./node_modules/html-webpack-plugin/lib/loader.js!./src/index.ejs] 1.74 KiB {HtmlWebpackPlugin_0} [built]
ℹ 「wdm」: Compiled successfully.
18:26:27.288 DEBUG (m/reac/preb/load-preferences) imported preferences: {"downloadSelfUpdates":true,"offlineMode":false,"installLocations":{},"defaultInstallLocation":"appdata","isolateApps":false,"closeToTray":true,"readyNotification":true,"showAdvanced":false,"openAtLogin":false,"openAsHidden":false,"manualGameUpdates":false,"preventDisplaySleep":true,"preferOptimizedPatches":false,"disableBrowser":false,"enableTabs":false,"importedOldInstallLocations":true}
18:26:27.375 DEBUG (m/net/register-itch-protocol) Registering itch: protocol for session with user agent Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) kitch/25.4.9-canary Chrome/87.0.4280.141 Electron/11.2.2 Safari/537.36
(node:113718) electron: The default of contextIsolation is deprecated and will be changing from false to true in a future release of Electron.  See https://github.com/electron/electron/issues/23506 for more information
18:26:27.670 INFO (m/reac/preboot) preboot ran in 385.00ms
18:26:27.672 WARN (m/reac/preboot) Could not find react devtools at /home/user/AppData/Local/Google/Chrome/User Data/Default/Extensions/fmkadmapgofadopljbjfkapdkoienihi: Error: ENOENT: no such file or directory, scandir '/home/user/AppData/Local/Google/Chrome/User Data/Default/Extensions/fmkadmapgofadopljbjfkapdkoienihi'
18:26:27.674 DEBUG (m/reac/open-at-login) Updating login item settings, open=false, hidden=false
18:26:27.674 DEBUG (m/reac/open-at-login) Copying /usr/share/applications/io.itch.kitch.desktop => /home/user/.config/autostart/io.itch.kitch.desktop
18:26:27.675 DEBUG (m/reac/winds) Waiting on root window to dispatch boot
18:26:28.301 INFO (m/reac/i18n) Language settings: preference undefined, sniffed en-US, fallback en
18:26:28.307 DEBUG (m/reac/locales) Reading local locale file /home/user/itch/src/static/locales/en.json
18:26:28.713 INFO (🔧 setup) Setup starting...
18:26:28.722 INFO (🔧 setup) Creating broth manager
18:26:28.744 INFO (🔧 setup) Ensuring broth dependencies, for startup
(node:113718) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
18:26:28.760 DEBUG (🔧 setup) Package (kitch) got version prefix
18:26:28.833 DEBUG (m/reac/locales) Reading local locale file /home/user/itch/src/static/locales/en.json
18:26:29.324 INFO (📦 butler) (69bd25daddd4b6b9f2b86cd6376e6ed522accfbb) is chosen and valid
18:26:29.325 INFO (📦 butler) Switching to (69bd25daddd4b6b9f2b86cd6376e6ed522accfbb)
18:26:29.326 DEBUG (🔧 setup) Package (butler) got version prefix
18:26:29.326 INFO (🔧 setup) Refreshing butlerd!
18:26:29.327 INFO (🔧 setup) Spinning up butlerd instance 1...
18:26:29.341 INFO (🔧 setup) ...waiting for endpoint from butlerd instance 1...
18:26:29.349 DEBUG (📦 itch-setup) spawning /home/user/.config/kitch/broth/itch-setup/versions/a14538db96c1f5c241c85beaa5c926e53b9626f0/itch-setup :: --version
18:26:29.555 INFO (📦 itch-setup) (a14538db96c1f5c241c85beaa5c926e53b9626f0) is chosen and valid
18:26:29.555 INFO (📦 itch-setup) Switching to (a14538db96c1f5c241c85beaa5c926e53b9626f0)
18:26:29.556 INFO (🔧 setup) In development, forcing components upgrade check
18:26:29.557 DEBUG (m/brot/itch-setup) spawning /home/user/.config/kitch/broth/itch-setup/versions/a14538db96c1f5c241c85beaa5c926e53b9626f0/itch-setup :: --appname ::: kitch ::: --upgrade
18:26:29.580 DEBUG (🔧 setup) Package (itch-setup) got version prefix
18:26:29.581 INFO (🔧 setup) ...for butlerd instance 1 got endpoint 127.0.0.1:35269
18:26:29.585 INFO (🔧 setup) Now speaking with butlerd instance 1, version head, built on Aug 28 2020 @ 17:22:40, ref 69bd25daddd4b6b9f2b86cd6376e6ed522accfbb, endpoint 127.0.0.1:35269
18:26:29.587 DEBUG (m/reac/down/driver) Downloads driver reacting to gotButlerdEndpoint, cancelling state...
18:26:29.587 DEBUG (m/reac/down/driver-persistent-state) Not cancelling, current phase is 0
18:26:29.587 DEBUG (m/reac/down/driver) Downloads driver reacting to gotButlerdEndpoint, state is cancelled...
18:26:29.588 DEBUG (m/reac/down/driver) Download driver polling...
18:26:29.588 DEBUG (mcall) Calling Downloads.List
18:26:29.641 DEBUG (📦 self) > 2021/02/22 13:26:29 itch-setup will log to /tmp/itch-setup-log.txt
18:26:29.642 DEBUG (📦 self) > 2021/02/22 13:26:29 =========================================
18:26:29.642 DEBUG (📦 self) > 2021/02/22 13:26:29 itch-setup "head, built on Aug 28 2020 @ 17:27:57, ref a14538db96c1f5c241c85beaa5c926e53b9626f0" starting up at "2021-02-22 13:26:29.640390498 -0500 EST m=+0.005275044" with arguments:
18:26:29.642 DEBUG (📦 self) > 2021/02/22 13:26:29 "/home/user/.config/kitch/broth/itch-setup/versions/a14538db96c1f5c241c85beaa5c926e53b9626f0/itch-setup"
18:26:29.642 DEBUG (📦 self) > 2021/02/22 13:26:29 "--appname"
18:26:29.643 DEBUG (📦 self) > 2021/02/22 13:26:29 "kitch"
18:26:29.643 DEBUG (📦 self) > 2021/02/22 13:26:29 "--upgrade"
18:26:29.643 DEBUG (📦 self) > 2021/02/22 13:26:29 =========================================
18:26:29.643 DEBUG (📦 self) > 2021/02/22 13:26:29 App name specified on command-line: kitch
18:26:29.643 DEBUG (📦 self) > 2021/02/22 13:26:29 Locale:  en-US
18:26:29.649 DEBUG (📦 self) > 2021/02/22 13:26:29 Initializing installer GUI...
18:26:29.650 DEBUG (📦 self) > 2021/02/22 13:26:29 Using GTK UI
18:26:29.650 DEBUG (📦 self) > Gtk-Message: 13:26:29.647: Failed to load module "appmenu-gtk-module"
18:26:29.793 DEBUG (📦 self) > 2021/02/22 13:26:29 Initializing (kitch) multiverse @ (/home/user/.kitch)
18:26:29.796 DEBUG (📦 self) > 2021/02/22 13:26:29 No multiverse information yet
18:26:29.819 DEBUG (📦 self) > 2021/02/22 13:26:29 No version currently installed
18:26:29.821 DEBUG (📦 self) > github.com/itchio/itch-setup/setup.(*Installer).Upgrade.func2
18:26:29.821 DEBUG (📦 self) > 	/builds/itchio/itch-setup/setup/upgrade.go:84
18:26:29.822 DEBUG (📦 self) > github.com/itchio/wharf/taskgroup.Do.func1
18:26:29.832 DEBUG (📦 self) > 	/root/go/pkg/mod/github.com/itchio/[email protected]/taskgroup/taskgroup.go:24
18:26:29.833 DEBUG (📦 self) > runtime.goexit
18:26:29.833 DEBUG (📦 self) > 	/usr/local/go/src/runtime/asm_amd64.s:1373
18:26:29.834 DEBUG (📦 self) > task 2
18:26:29.834 DEBUG (📦 self) > github.com/itchio/wharf/taskgroup.Do
18:26:29.834 DEBUG (📦 self) > 	/root/go/pkg/mod/github.com/itchio/[email protected]/taskgroup/taskgroup.go:37
18:26:29.835 DEBUG (📦 self) > github.com/itchio/itch-setup/setup.(*Installer).Upgrade
18:26:29.835 DEBUG (📦 self) > 	/builds/itchio/itch-setup/setup/upgrade.go:67
18:26:29.836 DEBUG (📦 self) > github.com/itchio/itch-setup/native.(*nativeCore).Upgrade
18:26:29.842 DEBUG (📦 self) > 	/builds/itchio/itch-setup/native/native_linux.go:245
18:26:29.843 DEBUG (📦 self) > main.main
18:26:29.843 DEBUG (📦 self) > 	/builds/itchio/itch-setup/main.go:218
18:26:29.843 DEBUG (📦 self) > runtime.main
18:26:29.843 DEBUG (📦 self) > 	/usr/local/go/src/runtime/proc.go:203
18:26:29.844 DEBUG (📦 self) > runtime.goexit
18:26:29.844 DEBUG (📦 self) > 	/usr/local/go/src/runtime/asm_amd64.s:1373
18:26:29.844 DEBUG (📦 self) > Fatal upgrade error
18:26:29.892 DEBUG (📦 butler) No semver constraint, going with /LATEST
18:26:29.893 DEBUG (📦 butler) GET (https://broth.itch.ovh/butler/linux-amd64-head/LATEST)
18:26:29.896 DEBUG (r) HTTP get https://broth.itch.ovh/butler/linux-amd64-head/LATEST
18:26:30.483 DEBUG (r) Got HTTP 200, content-length: 40 B
18:26:30.484 INFO (📦 butler) Latest is (69bd25daddd4b6b9f2b86cd6376e6ed522accfbb)
18:26:30.485 INFO (📦 butler) Already the active version, nothing to do
18:26:30.495 DEBUG (📦 butler) Present versions: 69bd25daddd4b6b9f2b86cd6376e6ed522accfbb
18:26:30.497 DEBUG (📦 itch-setup) No semver constraint, going with /LATEST
18:26:30.498 DEBUG (📦 itch-setup) GET (https://broth.itch.ovh/itch-setup/linux-amd64-head/LATEST)
18:26:30.498 DEBUG (r) HTTP get https://broth.itch.ovh/itch-setup/linux-amd64-head/LATEST
18:26:30.689 DEBUG (r) Got HTTP 200, content-length: 40 B
18:26:30.695 INFO (📦 itch-setup) Latest is (a14538db96c1f5c241c85beaa5c926e53b9626f0)
18:26:30.695 INFO (📦 itch-setup) Already the active version, nothing to do
18:26:30.697 DEBUG (📦 itch-setup) Present versions: a14538db96c1f5c241c85beaa5c926e53b9626f0
18:26:30.698 DEBUG (🔧 setup) Waiting for butler promise...
18:26:30.698 DEBUG (🔧 setup) Syncing install locations...
18:26:30.698 DEBUG (mcall) Calling Install.Locations.List
18:26:30.701 DEBUG (🔧 setup) Dispatching setup done!
18:26:30.701 INFO (🔧 setup) Setup done
18:26:30.703 DEBUG (mcall) Calling Fetch.Caves
18:26:30.704 INFO (m/reac/silent-location-scan) Scanning install locations for items...
18:26:30.704 DEBUG (mcall) Calling Install.Locations.Scan
18:26:30.709 INFO (m/reac/silent-location-scan) • Scanning install location /home/user/.config/kitch/apps...
18:26:30.709 INFO (m/reac/silent-location-scan) No items found
18:26:30.710 INFO (m/reac/silent-location-scan) Scan complete.
18:26:30.713 INFO Using tray image (/home/user/itch/src/static/images/tray/kitch.png)
18:26:30.719 DEBUG (mcall) Calling Fetch.Caves
18:26:30.720 DEBUG (mcall) Calling Fetch.Commons
18:26:30.714 DEBUG (rcall) Calling Profile.List
18:26:31.981 INFO (m/reac/login) Attempting saved login for profile 2382697
18:26:31.982 DEBUG (mcall) Calling Profile.UseSavedLogin
18:26:31.984 INFO (m/reac/login) • Validating credentials...
18:26:32.396 INFO (m/reac/login) • Logged in! (online)
18:26:32.397 INFO (m/reac/login) Saved login succeeded!
18:26:32.397 INFO (m/reac/login) Login succeeded, setting up session
18:26:32.400 INFO (m/reac/login) Registering itch protocol for session persist:itchio-2382697
18:26:32.400 DEBUG (m/net/register-itch-protocol) Registering itch: protocol for session with user agent Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) kitch/25.4.9-canary Chrome/87.0.4280.141 Electron/11.2.2 Safari/537.36
18:26:32.401 INFO (m/reac/login) Restoring tabs...
18:26:32.401 DEBUG (mcall) Calling Profile.Data.Get
18:26:32.405 INFO (m/reac/login) Dispatching login succeeded
18:26:32.406 INFO (m/reac/login) Fetching owned keys...
18:26:32.406 DEBUG (mcall) Calling Fetch.ProfileOwnedKeys
18:26:32.411 DEBUG (mcall) Calling Fetch.Commons
18:26:32.412 DEBUG (m/reac/down/driver) Download driver polling...
18:26:32.413 DEBUG (m/reac/down/driver) Not paused... current phase: IDLE
18:26:32.413 DEBUG (m/reac/down/driver-persistent-state) IDLE => STARTING
18:26:32.413 DEBUG (mcall) Calling Downloads.Drive
18:26:32.414 DEBUG (m/reac/down/driver-persistent-state) STARTING => RUNNING
18:26:32.414 INFO (m/reac/down/driver-persistent-state) Downloads started
18:26:32.431 INFO (m/reac/login) Fetching fresh data...
18:26:32.431 INFO (m/reac/login) Fetching page 1
18:26:32.432 INFO (m/reac/down/driver) Now driving downloads...
18:26:32.545 INFO (m/reac/login) Waited 126.421075ms for fetch (non-shared)
18:26:32.546 INFO (m/reac/login) Fetched owned keys in 139.00ms
18:26:32.566 DEBUG (rcall) Calling Fetch.Caves
(node:113718) electron: The default of contextIsolation is deprecated and will be changing from false to true in a future release of Electron.  See https://github.com/electron/electron/issues/23506 for more information
18:26:32.861 DEBUG (m/reac/web-contents) Loading url 'https://itch.io'
18:26:32.913 DEBUG (mcall) Calling Fetch.Commons
18:26:33.461 ERROR (m/crash-reporter) crash-reporter reporting: uncaught exception: TypeError: Cannot read property 'length' of undefined
18:26:34.583 DEBUG (m/reac/web-contents) did-finish-load (once)
18:26:36.281 DEBUG (mcall) Calling Profile.Data.Put
18:26:38.741 DEBUG (mcall) Calling Fetch.Commons
18:26:38.743 ERROR (mcall) Caught butler error:
18:26:38.743 ERROR (mcall) JavaScript stack: Error: connect ECONNREFUSED 127.0.0.1:35269
18:26:38.743 WARN (m/reac/commons) While fetching commons: Error: connect ECONNREFUSED 127.0.0.1:35269
18:26:38.744 INFO (🔧 setup) butlerd instance 1 has closed.
18:26:38.746 ERROR (mcall) Caught butler error:
18:26:38.746 ERROR (mcall) butler version: undefined
18:26:38.746 ERROR (mcall) Golang stack:
Error
18:26:38.746 ERROR (mcall) JavaScript stack: Error: JSON-RPC error -1000: JSON-RPC conversation cancelled
18:26:38.746 ERROR (m/reac/down/driver) Error: JSON-RPC error -1000: JSON-RPC conversation cancelled
18:26:38.746 DEBUG (m/reac/down/driver-persistent-state) RUNNING => IDLE
18:26:38.747 INFO (m/reac/down/driver-persistent-state) Downloads stopped
18:26:38.747 DEBUG (m/reac/down/driver) Going back to idle after Downloads.Drive call

TheGamer1002 avatar Feb 22 '21 18:02 TheGamer1002

Attached a debugger and the error appears to be coming from:

commit (/src/main/reactors/web-contents.ts:361)
<anonymous> (/src/main/reactors/web-contents.ts:512)
emit (Unknown Source:327)
callbackTrampoline (Unknown Source:120)

Edit: looks like the line numbers get changed (possibly related to WebPack?), so here is the code:

    const commit = (reason, event, url, // latest URL
    inPage, // in-page navigation (HTML5 pushState/popState/replaceState)
    replaceEntry // previous history entry was replaced
    ) => {
        if (wc.currentIndex < 0) {
            // We get those spurious events after a "clear history & loadURL()"
            // at this point `wc.history.length` is 0 anyway, so it's not like we
            // can figure out much. They're followed by a meaningful event shortly after.
            logger.debug(`Ignoring commit with negative currentIndex`);
            return;
        }
        let { previousIndex, previousHistorySize } = previousState;
        previousState = {
            previousIndex: wc.currentIndex,
            previousHistorySize: wc.history.length,  <---- wc.history is undefined
        };

jaredkrinke avatar Mar 01 '21 20:03 jaredkrinke

I'm not super familiar with the Itch app or Electron, but it seems like Itch is using undocumented properties which no longer exist, similar to https://github.com/electron/electron/issues/26727

jaredkrinke avatar Mar 01 '21 20:03 jaredkrinke

This report lines up with a previous attempt at upgrading Electron from 10 to 11 in Feb 2021 (rolled back in May 2021). Looks like this behavior has re-appeared now that @leafo is having another go at the upgrade (commit from Mar 2022)

aycyang avatar Jul 27 '22 04:07 aycyang