Ivica Taseski
Ivica Taseski
> > @catpineapple can you provide us with the necessary configuration to run the acceptance tests or instructions on how to create an account for selectdb? The service seems to...
@catpineapple please check my review comments
@catpineapple your tests seem broken. can you rerun them? you have updated the config in spec.json but it seems that you have forgotten in `SelectdbDestinationAcceptanceTest.java`. There are several other issues...
@catpineapple The connector is pretty hard to test. This is what I'mg getting on` testSync` `testSyncNotFailsWithNewFields` `testSyncNotFailsWithNewFields` ``` {"type":"LOG","log":{"level":"INFO","message":"redirect to s3 address:https://selectdb-online-us-east-1-bucket1668080392.s3.amazonaws.com/AWVAOLRZ/stage/admin/admin/_exchange_rate_99f6d9a7-c361-4576-950f-45c7b5449dba1677627426515.csv?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Date=20230228T233619Z&X-Amz-SignedHeaders=host&X-Amz-Expires=3600&X-Amz-Credential=AKIA3AUKURBS4Z65WP4C%2F20230228%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Signature=ad78c587f4d616b759044d46091bff8ea50a8dddd97bf2545fc6ffc08a6f715a"}} {"type":"LOG","log":{"level":"ERROR","message":"Failed to upload selectdb stage in destination: java.lang.RuntimeException:...
@catpineapple friendly reminder that you need to fix the acceptance tests if you want this connector to get merged. https://github.com/airbytehq/airbyte/pull/20881#issuecomment-1448656583 https://github.com/airbytehq/airbyte/pull/20881#issuecomment-1449076685
@catpineapple there are other issues to be resolved as well, merging master to you branch won't resolve them.
> @itaseskii Sorry my friend , something else has been delayed lately and it seems to have fixed the previous issue now. Please help me with the review @catpineapple is...
> > > > @itaseskii [[email protected]](mailto:[email protected]) @catpineapple I have sent you the config. Feel free to also login to my acc to see if everything is created as needed.
@catpineapple I can confirm that the connector is passing all the acceptance tests :partying_face: 
@catpineapple one last thing. your secrets/config.json path is wrong. Can you address this issue as suggested here: https://github.com/airbytehq/airbyte/pull/20881#discussion_r1140111330 https://github.com/airbytehq/airbyte/pull/20881#discussion_r1140112334 https://github.com/airbytehq/airbyte/pull/20881#discussion_r1140113041