crochet

crochet copied to clipboard

Experiments in making ParamSpec's work with the crochet typing support.

arnimarj

mypy plugin and coroutines

12

Hi, We just started integrating the 2.0 release into our codebase, and hit one issue. The `crochet.mypy` plugin is not checking if the function return value is a coroutine, it...

arnimarj

In async/await part of documentation, link to Django APIs

1

https://docs.djangoproject.com/en/3.2/topics/async/

itamarst

Apparently in old Python iscoroutinefunction could do better (and maybe the `asyncio` variant is better than the `inspect` variant? check.) See https://github.com/django/asgiref/blob/main/asgiref/sync.py#L32

itamarst

Use os.register_at_fork to make crochet work better with e.g. multiprocessing

2

https://docs.python.org/3/library/os.html#os.register_at_fork sounds like it might make Crochet not break when `multiprocessing` default mode is used.

itamarst

Python 3.7 has a queue that is re-entrancy safe, so in 3.7 we can omit the additional event loop used for the self-pipe trick. AFAICT there are no backports, though,...

itamarst

[EDITED] Document cancel-after-final-timeout pattern

10

I encountered an issue with crochet not terminating the twisted deferred correctly when raising the TimeoutError exception. ### Code for reference ``` python def test_eventual_result_timeout(server_url): # server incredibly slow eventual_result...

lucagiovagnoli

Document that running crochet tests in subclass of trial's TestCase may be a problem

2

This can lead to dirty reactor warnings. Suggest SynchronousTestCase instead.

itamarst

itamarst

wait_for and run_in_reactor swallow exceptions

11

Consider the following code: ``` python from __future__ import absolute_import, division, print_function from crochet import no_setup, wait_for, run_in_reactor no_setup() from twisted.trial import unittest as unittest_twisted import unittest as unittest_stdlib class...

hynek