developers.italia.it icon indicating copy to clipboard operation
developers.italia.it copied to clipboard

solved issue no 1124

Open Krish-bhardwaj opened this issue 2 years ago • 4 comments

Description

Hi i have solved this issue ( translated (https://developers.italia.it/en/legal-notice ) into english)

Krish-bhardwaj avatar Jan 10 '22 05:01 Krish-bhardwaj

Fails
:no_entry_sign:

There is a problem with the commit message

Fix: #1124

Hi i have fixed this issue requested to merge this PR

  • type must be lower-case
  • type must be one of [build, chore, ci, docs, feat, fix, perf, refactor, revert, style, test]
:no_entry_sign: There is a problem with the commit message > issue solved 1124 translated legal notice page to english - subject may not be empty - type may not be empty
:no_entry_sign: There is a problem with the commit message > issue #1124 solved - subject may not be empty - type may not be empty

Generated by :no_entry_sign: dangerJS against 952414015c931a2452cf0aff39f5d6a5ce8e316b

developers-italia-droid avatar Jan 10 '22 05:01 developers-italia-droid

Hi @developers-italia-droid i have fixed this issue and have changed the commit msg also still getting image just this one error plz guide me @ruphy @cloudify @gunzip

Krish-bhardwaj avatar Jan 13 '22 03:01 Krish-bhardwaj

Hello @Krish-bhardwaj, thanks for the PR!

The bot is complaining about the commit message format. We use and enforce conventional commits:

https://github.com/italia/developers.italia.it/blob/master/CONTRIBUTING.md#commit-messages and https://www.conventionalcommits.org/en/v1.0.0/

bfabio avatar Jan 13 '22 09:01 bfabio

#1156 was merged, but we should compare this translation as well to see if we can merge some improvements

bfabio avatar May 25 '22 10:05 bfabio