design-react-kit icon indicating copy to clipboard operation
design-react-kit copied to clipboard

Adding `alt` attribute to Icon components

Open dennybiasiolli opened this issue 2 years ago • 5 comments

Fixes #860

PR Checklist

  • [x] My branch is up-to-date with the Upstream master branch.
  • [x] The unit tests pass locally with my changes (if applicable).
  • [x] I have added tests that prove my fix is effective or that my feature works (if applicable).
  • [ ] I have added necessary documentation (if appropriate).

Short description of what this resolves:

This adds accessibility improvements for Icon and HeaderBrand components

Changes proposed in this Pull Request:

  • stories(AutocompleteExample): removing a warning in tests

    Parameter 'props' implicitly has an 'any' type

  • Icon: adding optional alt attribute in case of custom image

  • HeaderBrand: adding iconAlt optional attribute

  • Icon(assets): adding title element to svg icons

dennybiasiolli avatar Oct 10 '22 08:10 dennybiasiolli

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
design-react-kit ✅ Ready (Inspect) Visit Preview Oct 17, 2022 at 7:04AM (UTC)

vercel[bot] avatar Oct 10 '22 08:10 vercel[bot]

Thanks for the comments, will work on them 😉

dennybiasiolli avatar Oct 11 '22 07:10 dennybiasiolli

Thanks for the updates. I hope to check it tomorrow, and hopefully approve it 👍

dej611 avatar Oct 13 '22 07:10 dej611

Thanks! Meanwhile I rebased this PR on top of current master branch 😉

dennybiasiolli avatar Oct 13 '22 07:10 dennybiasiolli

Codecov Report

Merging #864 (e68e66f) into master (d2baa1b) will increase coverage by 0.50%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #864      +/-   ##
==========================================
+ Coverage   97.28%   97.78%   +0.50%     
==========================================
  Files         237      237              
  Lines        2724     3341     +617     
  Branches      478      602     +124     
==========================================
+ Hits         2650     3267     +617     
  Misses         74       74              
Flag Coverage Δ
unittests 97.78% <100.00%> (+0.50%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Header/HeaderBrand.tsx 96.87% <100.00%> (+0.10%) :arrow_up:
src/Icon/EmptyIcon.tsx 100.00% <100.00%> (ø)
src/Icon/Icon.tsx 100.00% <100.00%> (ø)
src/Icon/assets/ItArrowDown.tsx 100.00% <100.00%> (ø)
src/Icon/assets/ItArrowDownCircle.tsx 100.00% <100.00%> (ø)
src/Icon/assets/ItArrowDownTriangle.tsx 100.00% <100.00%> (ø)
src/Icon/assets/ItArrowLeft.tsx 100.00% <100.00%> (ø)
src/Icon/assets/ItArrowLeftCircle.tsx 100.00% <100.00%> (ø)
src/Icon/assets/ItArrowLeftTriangle.tsx 100.00% <100.00%> (ø)
src/Icon/assets/ItArrowRight.tsx 100.00% <100.00%> (ø)
... and 115 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Oct 13 '22 07:10 codecov[bot]

Thanks @dennybiasiolli for the PR! 🎉

dej611 avatar Oct 17 '22 07:10 dej611