design-react-kit icon indicating copy to clipboard operation
design-react-kit copied to clipboard

[FEATURE] Make component support the cssModules prop as in reactstrap

Open dej611 opened this issue 5 years ago • 4 comments

Is your feature request related to a problem? Please describe. reactstrap has a styling overwrite mechanism with a cssModules prop that lets the user handle scenarios where classes are either different (custom-compiled css framework) or not required (edge cases for some special component)

Describe the solution you'd like Integrate together with the classNames mechanism also the cssModules one. Some components already have it (i.e. Input) but tohers don't.

Describe alternatives you've considered No alternative

dej611 avatar Oct 30 '19 07:10 dej611

@dej611 Okay, so we need to use mapToCssModules from the reactstrap library or do we need to create a separate one for this kit ?
Also, do all components require this feature ? If not, let's list the components that require this. I'd like to work on it.

ankushbhardwxj avatar Jan 17 '20 19:01 ankushbhardwxj

@dej611 any update on this ?

ankushbhardwxj avatar Feb 05 '20 17:02 ankushbhardwxj

First list of components (WIP):

  • [ ] Accordion
  • [ ] Avatar
  • [ ] BottomNav
  • [ ] Button
  • [ ] Callout

dej611 avatar Feb 06 '20 08:02 dej611

Okay, so we need to use mapToCssModules from the reactstrap library or do we need to create a separate one for this kit ?

If exported we can use it, otherwise we need to implement one internally.

Also, do all components require this feature ? If not, let's list the components that require this.

Generally speaking, if a component is using a classname from BI, then it is required to have this feature.

dej611 avatar Mar 10 '20 08:03 dej611

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please read https://github.com/italia/design-react-kit/discussions/886.

stale[bot] avatar Dec 11 '23 12:12 stale[bot]