bootstrap-italia
bootstrap-italia copied to clipboard
feat: add a way to reject cookies with Cookiebar
- Document preference cookie name saved by the cookiebar
- Make the cookie expire after 6 months
- Add a close and a reject button in the example, as per guidelines, and their data attribute (data-close="cookiebar).
- Update the example with the new message
- [x] Le modifiche sono conformi alle linee guida di design.
- [x] Il codice è coerente con le indicazioni di progetto.
- [ ] Le modifiche sono state verificate sui Browser supportati e per diverse risoluzioni dello schermo.
- [ ] Sono stati effettuati test di accessibilità in ottemperanza a quanto descritto nell'area "Accessibilità" delle linee guida di design.
- [x] La documentazione è stata aggiornata.
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/dip-trasformazione-digitale/bootstrap-italia/6DL1ST91MKZPAdneZR333ABiTeMF
✅ Preview: https://bootstrap-italia-git-fork-bf-d31f1a-dip-trasformazione-digitale.vercel.app
@gpeirolo please check the a11y of this updated component markup, eg. keyboard interactions... cc @cfabry
@Fupete the markup is correct and keyboard interaction works fine (tabbing and moving with arrows to buttons and links).
Screen reader experience presents some problems:
- the dialog is not announced when the page is loaded (aria-live seems to be ineffective, perhaps because its content is already there)
- the "x" character is read as "per" (should be hidden with aria-hidden)
- the user must navigate the entire page to get to the cookiebar
Further review by @cfabry is advisable.
@gpeirolo indeed it is. I ping @cfabry also on slack in a moment.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@stale mind your business
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@stale :-1:
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
nope @stale tx
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Updated |
---|---|---|---|
bootstrap-italia | ✅ Ready (Inspect) | Visit Preview | Jan 11, 2023 at 9:07PM (UTC) |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.