bootstrap-italia icon indicating copy to clipboard operation
bootstrap-italia copied to clipboard

feat: add a way to reject cookies with Cookiebar

Open bfabio opened this issue 2 years ago • 8 comments

  • Document preference cookie name saved by the cookiebar
  • Make the cookie expire after 6 months
  • Add a close and a reject button in the example, as per guidelines, and their data attribute (data-close="cookiebar).
  • Update the example with the new message

bfabio avatar Mar 19 '22 11:03 bfabio

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/dip-trasformazione-digitale/bootstrap-italia/6DL1ST91MKZPAdneZR333ABiTeMF
✅ Preview: https://bootstrap-italia-git-fork-bf-d31f1a-dip-trasformazione-digitale.vercel.app

vercel[bot] avatar Mar 19 '22 11:03 vercel[bot]

@gpeirolo please check the a11y of this updated component markup, eg. keyboard interactions... cc @cfabry

Fupete avatar Mar 19 '22 11:03 Fupete

@Fupete the markup is correct and keyboard interaction works fine (tabbing and moving with arrows to buttons and links).

Screen reader experience presents some problems:

  • the dialog is not announced when the page is loaded (aria-live seems to be ineffective, perhaps because its content is already there)
  • the "x" character is read as "per" (should be hidden with aria-hidden)
  • the user must navigate the entire page to get to the cookiebar

Further review by @cfabry is advisable.

gpeirolo avatar Mar 21 '22 10:03 gpeirolo

@gpeirolo indeed it is. I ping @cfabry also on slack in a moment.

Fupete avatar Mar 21 '22 13:03 Fupete

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar May 28 '22 08:05 stale[bot]

@stale mind your business

bfabio avatar May 28 '22 09:05 bfabio

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 10 '22 21:09 stale[bot]

@stale :-1:

bfabio avatar Sep 11 '22 14:09 bfabio

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jan 04 '23 20:01 stale[bot]

nope @stale tx

Fupete avatar Jan 11 '23 21:01 Fupete

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
bootstrap-italia ✅ Ready (Inspect) Visit Preview Jan 11, 2023 at 9:07PM (UTC)

vercel[bot] avatar Jan 11 '23 21:01 vercel[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Mar 12 '23 21:03 stale[bot]