StreetCode icon indicating copy to clipboard operation
StreetCode copied to clipboard

Fixing issue with 200 status code when no Id matches were found

Open Michael-Kolpakov opened this issue 1 year ago • 0 comments

Ticket

Code reviewers

  • [ ] @mythter
  • [ ] @sashapanasiuk5
  • [ ] @ita-social-projects/734-08-streetcode

Summary of issue

  • When no matches were found for Id, an empty collection was returned with 200 status code instead of a 404 error.

Summary of change

  • Now, when we cannot find any related figures by id server returns 404 error.

CHECK LIST

  • [ ] СI passed
  • [ ] Сode coverage >=95%
  • [ ] PR is reviewed manually again (to make sure you have 100% ready code)
  • [ ] All reviewers agreed to merge the PR
  • [ ] I've checked new feature as logged in and logged out user if needed
  • [ ] PR meets all conventions

Michael-Kolpakov avatar Sep 09 '24 11:09 Michael-Kolpakov