odoo-saas-tools icon indicating copy to clipboard operation
odoo-saas-tools copied to clipboard

Published 20 hours ago • verified publisher icon it-projects-llc

10.0 1464 2

Open iledarn opened this issue 7 years ago • 11 comments

iledarn avatar Apr 20 '17 09:04 iledarn

@iledarn resolve conflicts or close

yelizariev avatar Jun 14 '17 06:06 yelizariev

@yelizariev , This PR is not for merging it has an experimental code that we don't need in main repository. I've created it for @ilmir-k to test. Is it a problem?

iledarn avatar Jun 16 '17 08:06 iledarn

@yelizariev , I've cherry-picked some commits from it to the main repository already

iledarn avatar Jun 16 '17 08:06 iledarn

It's better to have clean list of pull requests. Do you still need it?

yelizariev avatar Jun 16 '17 16:06 yelizariev

I don't need it. Does Ilmir need it?

iledarn avatar Jun 19 '17 05:06 iledarn

I think it will be better to close it, when we complete the project on signup form customization. This PR allows me to easily test updates on runbot.

ilmir-k avatar Jun 19 '17 07:06 ilmir-k

@yelizariev , Ilmir didn't say that you may close it

iledarn avatar Jun 19 '17 09:06 iledarn

@iledarn why don't you want to merge it?

yelizariev avatar Jun 20 '17 15:06 yelizariev

You can run your own runbot attached to your fork for updates that are not going to be merged, but

  • I don't like idea to create PR that is not going to be merged.
  • I don't like to develop modules that is not going to be merged either.

yelizariev avatar Jun 20 '17 15:06 yelizariev

@yelizariev , I don't want to merge because some of the code is suitable for only one customer. I've cherry-picked general commits from here already

iledarn avatar Jun 20 '17 18:06 iledarn

recaptcha can be useful for many users. Have you merged it?

yelizariev avatar Jun 21 '17 07:06 yelizariev