digiwf-core icon indicating copy to clipboard operation
digiwf-core copied to clipboard

Feature/1442 move duplicate s3 logic to client libs

Open markostreich opened this issue 1 year ago • 1 comments

Description

Reference

Issues: #xxx

Screenshots (If UI changed)

Check-List

  • [x] All Acceptance criteria of user story are met
  • [x] Accessibility was considered and tested (On UI Change)
  • [ ] JUnit tests are written (60% CodeCov)
  • [ ] Internal Review is maintained
  • [x] Documentations external and internal are completed
  • [ ] Smoketest successful (Manual E2E-Test depending on Change)
  • [ ] No waste on Branch left (e.g. console.logs)
  • [ ] Board is up-to-date
  • [ ] Internal Services / Artifacts updated (Depending on Change - See Dependency Graph)
  • [ ] Openshift environments are prepared (Secrets, etc.) and release-issue is maintained

markostreich avatar May 15 '24 09:05 markostreich

Codecov Report

Attention: Patch coverage is 63.97516% with 58 lines in your changes missing coverage. Please review.

Project coverage is 44.65%. Comparing base (6f7c1ae) to head (90d8a3a). Report is 3 commits behind head on dev.

Files Patch % Lines
...e/client/controller/ClientFileUsageController.java 0.00% 13 Missing :warning:
...giwf/dms/integration/adapter/out/s3/S3Adapter.java 68.00% 7 Missing and 1 partial :warning:
.../repository/transfer/S3FileTransferRepository.java 68.00% 8 Missing :warning:
...f/ticket/integration/adapter/out/s3/S3Adapter.java 46.15% 7 Missing :warning:
...n/api/resource/ServiceStartFileRestController.java 0.00% 4 Missing :warning:
...nition/domain/service/ServiceStartFileService.java 0.00% 4 Missing :warning:
...nce/domain/service/ServiceInstanceFileService.java 0.00% 4 Missing :warning:
...en/oss/digiwf/shared/file/AbstractFileService.java 0.00% 3 Missing :warning:
...tegration/client/service/FileExtensionService.java 82.35% 2 Missing and 1 partial :warning:
...client/controller/ClientFolderUsageController.java 0.00% 2 Missing :warning:
... and 2 more
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #1684      +/-   ##
============================================
- Coverage     44.73%   44.65%   -0.09%     
- Complexity     1706     1707       +1     
============================================
  Files           653      656       +3     
  Lines          9629     9592      -37     
  Branches        477      482       +5     
============================================
- Hits           4308     4283      -25     
+ Misses         5139     5124      -15     
- Partials        182      185       +3     
Flag Coverage Δ
unittests 44.65% <63.97%> (-0.09%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 15 '24 09:05 codecov[bot]

Der Multi File Input funktioniert bei mir nicht mehr.

@lehju Sollte nun repariert sein.

markostreich avatar May 25 '24 19:05 markostreich