ztunnel
ztunnel copied to clipboard
istio
Bump rust version to 1.78
@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| test_ztunnel | d8b206f43dea4b4fd456eb272cbfd614606f60cf | link | true | /test test |
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
maybe we shouldn't dothis since we don't require 1.78, and this will make it fail on 1.77?
Yeah I think we need to track our CI version/build-tools version exactly in the Cargo.toml
rust-version is the 'The minimal supported Rust version.' We run fine on 1.77, do we really want to say you MUST have 1.78?
Build tools is fine since that is managed. I don't personally care since I always use latest. But seems a bit excessive
rust-version is the 'The minimal supported Rust version.' We run fine on 1.77, do we really want to say you MUST have 1.78?
I think our min version can only be the min version we actually build and test with.
People are free to try and change it and set it lower, but our floor sort of has to be what we use in CI, we can't make strong claims about any other version.