tools
tools copied to clipboard
istio
(feat) Add cargo-deny for build
😊 Welcome @hypernovasunnix! This is either your first contribution to the Istio tools repo, or it's been awhile since you've been here.
You can learn more about the Istio working groups, code of conduct, and contributing guidelines by referring to Contributing to Istio.
Thanks for contributing!
Courtesy of your friendly welcome wagon.
Hi @hypernovasunnix. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@hypernovasunnix: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| containers-test-arm64_tools | f4a1e0e76f57074a4b16469c8c648f7b8334f806 | link | true | /test containers-test-arm64 |
| lint_tools | f4a1e0e76f57074a4b16469c8c648f7b8334f806 | link | true | /test lint |
| containers-test_tools | f4a1e0e76f57074a4b16469c8c648f7b8334f806 | link | true | /test containers-test |
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
Semi-unrelated question - at some point do we plan to create a separate build-tools-ztunnel output image/stage, much like we have for build-tools-proxy?
As we start adding more rust/cargo deps it might begin to make sense.
We did have a quick discussion when rust wast added to the image. It would be good to compare sizes occasionally to see what savings we have both ways.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.