tools icon indicating copy to clipboard operation
tools copied to clipboard

Add automated security policy test scripts

Open MichaelEizaguirre opened this issue 4 years ago • 10 comments

These new files added allow for users to run some pre-defined security policy tests. The READ.md also reflects the changes

MichaelEizaguirre avatar Sep 03 '20 09:09 MichaelEizaguirre

Hi @MichaelEizaguirre. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

istio-testing avatar Sep 03 '20 09:09 istio-testing

@yangminzhu @carolynhu

MichaelEizaguirre avatar Sep 03 '20 09:09 MichaelEizaguirre

/ok-to-test

ericvn avatar Sep 03 '20 13:09 ericvn

The name of these scripts may be slightly misleading as they are rather scripts that run the performance tests on certain security policies.

MichaelEizaguirre avatar Sep 03 '20 16:09 MichaelEizaguirre

Hey guys, I've put a temporary hold on this PR. It's not clear to me why we're not creating standard Golang tests for security. Can someone explain the use of test scripts instead? Are these load/stability tests?

FYI @howardjohn

nmittler avatar Sep 08 '20 14:09 nmittler

@nmittler yep this is to add tests to run with the performance benchmark pipeline

richardwxn avatar Sep 08 '20 18:09 richardwxn

Hey guys, I've put a temporary hold on this PR. It's not clear to me why we're not creating standard Golang tests for security. Can someone explain the use of test scripts instead? Are these load/stability tests?

FYI @howardjohn

Hi @nmittler

  • those standard Golang tests should be in a separate PR for his generating security policy features.
  • this PR is to automate the process of running a variety of performance tests with several general use cases of security policy applied.

carolynhu avatar Sep 08 '20 18:09 carolynhu

Hey guys, I've put a temporary hold on this PR. It's not clear to me why we're not creating standard Golang tests for security. Can someone explain the use of test scripts instead? Are these load/stability tests?

FYI @howardjohn

This PR is really just adding some shell scripts to make it easier to run the existing perf tests, not adding any new tests for security.

yangminzhu avatar Sep 09 '20 23:09 yangminzhu

@MichaelEizaguirre: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

istio-testing avatar Oct 03 '20 18:10 istio-testing

@MichaelEizaguirre: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
lint_tools 99a2f6e523281d8300b4a90ab324b5d5f9ba24e0 link /test lint_tools
benchmark_check_tools 99a2f6e523281d8300b4a90ab324b5d5f9ba24e0 link /test benchmark_check_tools
containers-test-arm64_tools 99a2f6e523281d8300b4a90ab324b5d5f9ba24e0 link true /test containers-test-arm64

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

istio-testing avatar Oct 14 '22 15:10 istio-testing