release-builder icon indicating copy to clipboard operation
release-builder copied to clipboard

Add RPM packages for CentOS 7 to the release

Open alexvanboxel opened this issue 3 years ago • 15 comments

alexvanboxel avatar Jul 14 '21 21:07 alexvanboxel

😊 Welcome @alexvanboxel! This is either your first contribution to the Istio release-builder repo, or it's been awhile since you've been here.

You can learn more about the Istio working groups, code of conduct, and contributing guidelines by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

istio-policy-bot avatar Jul 14 '21 21:07 istio-policy-bot

Hi @alexvanboxel. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

istio-testing avatar Jul 14 '21 21:07 istio-testing

For whoever reviews this, we need the CentOS 7 RPM's, once approved how can this be backported to the 1.10 and 1.11 branch?

alexvanboxel avatar Jul 15 '21 07:07 alexvanboxel

I think this needs broader discussion on if the project will official support another platform, which has a testing, maintenance, etc cost.

howardjohn avatar Jul 15 '21 17:07 howardjohn

The binaries are already built, we've extracted them from a docker file now. Enterprises are not switching to CentOS 8 as it doesn't offer the long-term support that CentOS 7 delivers. Another reason why it should be supported is that the main reason to join the VM to a mesh is to gradually decompose a legacy system into microservices. If Istio is not going to support the last LTS type in the CentOS line why support VM's at all?

alexvanboxel avatar Jul 15 '21 18:07 alexvanboxel

It was one of the 1.10 milestones: https://github.com/istio/istio/milestone/24

alexvanboxel avatar Jul 16 '21 07:07 alexvanboxel

I think this needs broader discussion on if the project will official support another platform, which has a testing, maintenance, etc cost.

How can we start this broader discussion? What's the right forum?

alexvanboxel avatar Jul 18 '21 05:07 alexvanboxel

@istio/wg-test-and-release-maintainers team, can you suggest how to move this forward for @alexvanboxel? can we discuss this in an upcoming WG mtg?

linsun avatar Aug 03 '21 15:08 linsun

@alexvanboxel I recommend you consider joining one of the upcoming build/test/release WG mtg: https://github.com/istio/community/blob/master/WORKING-GROUPS.md#working-group-meetings

linsun avatar Aug 03 '21 15:08 linsun

The binaries are already built, we've extracted them from a docker file now. Enterprises are not switching to CentOS 8 as it doesn't offer the long-term support that CentOS 7 delivers.

Just came here to emphasize this. Any chance of this PR moving forward?

Many enterprises never migrated from CentOS 7 to CentOS 8. Those that have migrated to CentOS 8 are looking to migrate away, since CentOS 8 is going EOL soon. It is commonly thought that CentOS Stream 8 cannot replace CentOS 8. More viable alternatives, such as Rocky Linux, have popped up (even Google is providing Rocky Linux VMs now).

Those that are still using CentOS 7 have no plans to switch to CentOS 8 nor CentOS Stream 8.

CentOS 7 goes EOL 2024-06-30 CentOS 8 goes EOL 2021-12-31

This of course wasn't always the situation. CentOS 8 was supposed to be long-term supported. RedHat decided it is not.

mikmatko avatar Sep 22 '21 14:09 mikmatko

@istio/wg-test-and-release-maintainers team, can you suggest how to move this forward for @alexvanboxel? can we discuss this in an upcoming WG mtg?

cc @linsun @alexvanboxel

I've added this to the T&R workgroup agenda for 9/28. Please attend to give your feedback. We are not committing to supporting CentOS 7 at this time, but in light of new information we can re-evaluate our position.

jacob-delgado avatar Sep 22 '21 20:09 jacob-delgado

We have a misunderstanding here.

The current centos rpm package is actually made for centos 7. See this check and the base image where it is built. This image is used to build centos proxy in prow.

So, from my understanding, nothing needs to be done.

jwendell avatar Sep 22 '21 22:09 jwendell

hmm, never mind what I said. The envoy-centos binary is indeed for centos7 but the ordinary envoy works in centos8 and debian, and it's this one that's shipped. I got it.

So we are already building and testing envoy for centos7, only not shipping the resulting rpm in the release process. I don't think in any problem or additional cost in shipping it.

We could also rename current rpm to centos-8 so we end up shipping centos7 and centos8 rpm's, to make it more clear.

jwendell avatar Sep 23 '21 01:09 jwendell

We did discuss this on today's T&R WG call. The author of this PR did not attend, but we did spend a fair amount of time discussing it. Some of the comments raised included:

  • Concern about the older glibc and Envoy support long-term.
  • Not sure of current community commitment to continue to support another RPM long-term from the current attendees. Producing the image does imply support going forward for some amount of time. If there is an issue 1-yr down the road, who is going to look into it? A testing requirement was also mentioned.
  • istio-ecosystem might be a way to make it available and not put hardship on the community for long-term on-going support.

Some additional comments:

  • Who will be users of the new RPM?
    • Will we see a migration of CentOS 8 users back to CentOS 7 at the end of the year because they don't want to move to CentOS Stream? Or will they move to some other Linux?
    • Will there be new users if CentOS 7 is going away at the end of 2024?
    • This might be more of a question for the Environments WG. What is seen as a requirement going forward?

Some unanswered questions from the Istio standpoint. If CentOS 8 is no longer supported, do we need to continue support the CentOS 8 RPM, do we move to CentOS Stream or should we announce support ending as well?

  • One thought would be to switch from providing a CentOS 8 RPM instead to a CentOS 7 RPM. But that still leads to the questions above.

ericvn avatar Sep 28 '21 19:09 ericvn

@alexvanboxel: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

istio-testing avatar Oct 25 '22 22:10 istio-testing