proxy icon indicating copy to clipboard operation
proxy copied to clipboard

(wip) stackdriver: add cluster name labels

Open douglas-reid opened this issue 2 years ago • 12 comments

Adds support for (source|destination)_cluster_name labels to Stackdriver extension.

douglas-reid avatar Oct 21 '21 19:10 douglas-reid

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

istio-testing avatar Oct 21 '21 19:10 istio-testing

/test all

douglas-reid avatar Oct 21 '21 19:10 douglas-reid

/test all

douglas-reid avatar Oct 21 '21 20:10 douglas-reid

/test test_proxy

douglas-reid avatar Oct 21 '21 20:10 douglas-reid

/test test_proxy

douglas-reid avatar Oct 21 '21 20:10 douglas-reid

/test test_proxy

douglas-reid avatar Oct 21 '21 21:10 douglas-reid

/retest

ericvn avatar Oct 26 '21 14:10 ericvn

Looks good as long as it is consistent, would appreciate a canonical doc with links to where the names come from.

costinm avatar Oct 26 '21 14:10 costinm

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Nov 04 '21 20:11 google-cla[bot]

/test test_proxy

douglas-reid avatar Nov 04 '21 20:11 douglas-reid

/test test_proxy

douglas-reid avatar Nov 04 '21 20:11 douglas-reid

/test all

douglas-reid avatar Nov 04 '21 21:11 douglas-reid

@douglas-reid: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

istio-testing avatar Sep 08 '22 03:09 istio-testing